Re: [PATCH] check to see if null pointer is dereferenceable [PR102630]

2021-10-13 Thread Martin Sebor via Gcc-patches
On 10/13/21 2:25 AM, Richard Biener wrote: On Wed, Oct 13, 2021 at 3:32 AM Martin Sebor via Gcc-patches wrote: On 10/11/21 6:26 PM, Joseph Myers wrote: The testcase uses the __seg_fs address space, which is x86-specific, but it isn't in an x86-specific directory or otherwise restricted to x86

Re: [PATCH] check to see if null pointer is dereferenceable [PR102630]

2021-10-13 Thread Richard Biener via Gcc-patches
On Wed, Oct 13, 2021 at 3:32 AM Martin Sebor via Gcc-patches wrote: > > On 10/11/21 6:26 PM, Joseph Myers wrote: > > The testcase uses the __seg_fs address space, which is x86-specific, but > > it isn't in an x86-specific directory or otherwise restricted to x86 > > targets; thus, I'd expect it to

Re: [PATCH] check to see if null pointer is dereferenceable [PR102630]

2021-10-12 Thread Martin Sebor via Gcc-patches
On 10/11/21 6:26 PM, Joseph Myers wrote: The testcase uses the __seg_fs address space, which is x86-specific, but it isn't in an x86-specific directory or otherwise restricted to x86 targets; thus, I'd expect it to fail for other architectures. This is not a review of the rest of the patch. G

Re: [PATCH] check to see if null pointer is dereferenceable [PR102630]

2021-10-11 Thread Joseph Myers
The testcase uses the __seg_fs address space, which is x86-specific, but it isn't in an x86-specific directory or otherwise restricted to x86 targets; thus, I'd expect it to fail for other architectures. This is not a review of the rest of the patch. -- Joseph S. Myers jos...@codesourcery.com

[PATCH] check to see if null pointer is dereferenceable [PR102630]

2021-10-09 Thread Martin Sebor via Gcc-patches
When determining the size of an object compute_objsize_r() assumes that addresses derived from null pointers are not derefernceable because null pointers themselves are not, without calling targetm.addr_space.zero_address_valid() to see if that assumption is supported for the pointer on the target