Re: [PATCH] canonical type hashing

2017-05-03 Thread Nathan Sidwell
On 05/03/2017 07:32 AM, Richard Biener wrote: On Tue, May 2, 2017 at 3:50 PM, Nathan Sidwell wrote: Looks ok to me. The new function name 'type_hash_default' is a little odd, maybe name it type_hash_canon_hash instead? sure. I think when I originally broke it out, I didn't know it would e

Re: [PATCH] canonical type hashing

2017-05-03 Thread Richard Biener
On Tue, May 2, 2017 at 3:50 PM, Nathan Sidwell wrote: > On the modules branch, I need rematerialize canonical types and the like > from a read-in serialized tree. > > I discovered the canonical-type hash table is fed a bespoke hash value by > each type creator. There was no generic type hasher :(

[PATCH] canonical type hashing

2017-05-02 Thread Nathan Sidwell
On the modules branch, I need rematerialize canonical types and the like from a read-in serialized tree. I discovered the canonical-type hash table is fed a bespoke hash value by each type creator. There was no generic type hasher :( The rationale appears to allow each type constuctor to just