Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-09-17 Thread Patrick Palka via Gcc-patches
On Thu, 10 Sep 2020, Patrick Palka wrote: > On Thu, 10 Sep 2020, David Malcolm wrote: > > > On Tue, 2020-07-28 at 20:22 -0400, Patrick Palka wrote: > > > On Tue, 28 Jul 2020, David Malcolm wrote: > > > > > > > On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > > > > > Currently the -Wmisl

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-09-10 Thread Patrick Palka via Gcc-patches
On Thu, 10 Sep 2020, David Malcolm wrote: > On Tue, 2020-07-28 at 20:22 -0400, Patrick Palka wrote: > > On Tue, 28 Jul 2020, David Malcolm wrote: > > > > > On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > > > > Currently the -Wmisleading-indentation warning doesn't do any > > > > analysi

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-09-10 Thread David Malcolm via Gcc-patches
On Tue, 2020-07-28 at 20:22 -0400, Patrick Palka wrote: > On Tue, 28 Jul 2020, David Malcolm wrote: > > > On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > > > Currently the -Wmisleading-indentation warning doesn't do any > > > analysis > > > when the guarded statement or the statement aft

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-09-10 Thread Patrick Palka via Gcc-patches
On Mon, 10 Aug 2020, Patrick Palka wrote: > On Tue, 28 Jul 2020, Patrick Palka wrote: > > > Currently the -Wmisleading-indentation warning doesn't do any analysis > > when the guarded statement or the statement after it is produced by a > > macro, as the mentioned PR illustrates. This means that

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-08-10 Thread Patrick Palka via Gcc-patches
On Tue, 28 Jul 2020, Patrick Palka wrote: > Currently the -Wmisleading-indentation warning doesn't do any analysis > when the guarded statement or the statement after it is produced by a > macro, as the mentioned PR illustrates. This means that we warn for: > > if (flag) > foo (); > ba

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-07-28 Thread Patrick Palka via Gcc-patches
On Tue, 28 Jul 2020, David Malcolm wrote: > On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > > Currently the -Wmisleading-indentation warning doesn't do any > > analysis > > when the guarded statement or the statement after it is produced by a > > macro, as the mentioned PR illustrates.

Re: [PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-07-28 Thread David Malcolm via Gcc-patches
On Tue, 2020-07-28 at 15:50 -0400, Patrick Palka wrote: > Currently the -Wmisleading-indentation warning doesn't do any > analysis > when the guarded statement or the statement after it is produced by a > macro, as the mentioned PR illustrates. This means that we warn for: > > if (flag) > f

[PATCH] c-family: Macro support in -Wmisleading-indentation [PR80076]

2020-07-28 Thread Patrick Palka via Gcc-patches
Currently the -Wmisleading-indentation warning doesn't do any analysis when the guarded statement or the statement after it is produced by a macro, as the mentioned PR illustrates. This means that we warn for: if (flag) foo (); bar (); and yet we don't warn for: #define BAR bar if