Re: [PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-25 Thread Jakub Jelinek via Gcc-patches
On Tue, May 24, 2022 at 09:59:03AM -0400, David Malcolm wrote: > > Ideally we'd have an automated check that the fix-it hint fixes the > > code, but failing that, I like to have at least some DejaGnu test > > coverage for fix-it hints - something like the tests in > > gcc.dg/fixits.c > > or gcc.dg/

Re: [PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-25 Thread Jakub Jelinek via Gcc-patches
On Tue, May 24, 2022 at 09:43:54AM -0400, Marek Polacek wrote: > Consider extending the test like Done, + added the dg-*-multiline-output stuff to test the fixit hints. Thanks. Here is what I've committed: 2022-05-25 Jakub Jelinek PR c/91134 gcc/c/ * c-tree.h (build_componen

Re: [PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-24 Thread David Malcolm via Gcc-patches
On Tue, 2022-05-24 at 09:57 -0400, David Malcolm wrote: > On Tue, 2022-05-24 at 09:25 +0200, Jakub Jelinek via Gcc-patches > wrote: > > Hi! > > > > On the following testcase (the first dg-error line) we emit a weird > > diagnostics and even fixit on pointerpointer->member > > where pointerpointer

Re: [PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-24 Thread David Malcolm via Gcc-patches
On Tue, 2022-05-24 at 09:25 +0200, Jakub Jelinek via Gcc-patches wrote: > Hi! > > On the following testcase (the first dg-error line) we emit a weird > diagnostics and even fixit on pointerpointer->member > where pointerpointer is pointer to pointer to struct and we say > 'pointerpointer' is a poi

Re: [PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-24 Thread Marek Polacek via Gcc-patches
On Tue, May 24, 2022 at 09:25:57AM +0200, Jakub Jelinek wrote: > Hi! > > On the following testcase (the first dg-error line) we emit a weird > diagnostics and even fixit on pointerpointer->member > where pointerpointer is pointer to pointer to struct and we say > 'pointerpointer' is a pointer; did

[PATCH] c: Improve build_component_ref diagnostics [PR91134]

2022-05-24 Thread Jakub Jelinek via Gcc-patches
Hi! On the following testcase (the first dg-error line) we emit a weird diagnostics and even fixit on pointerpointer->member where pointerpointer is pointer to pointer to struct and we say 'pointerpointer' is a pointer; did you mean to use '->'? The first part is indeed true, but suggesting -> whe