Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'

2024-01-22 Thread Richard Biener
On Mon, Jan 22, 2024 at 3:27 PM Hans-Peter Nilsson wrote: > > > From: Richard Biener > > Date: Mon, 22 Jan 2024 08:33:47 +0100 > > > > - "% function might not be inlinable"); > > > + "% function is not always inlined" > > > + " unless also dec

Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'

2024-01-22 Thread Hans-Peter Nilsson
> From: Richard Biener > Date: Mon, 22 Jan 2024 08:33:47 +0100 > > - "% function might not be inlinable"); > > + "% function is not always inlined" > > + " unless also declared %"); > > I don't like the "is not always inlined", maybe simply r

Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'

2024-01-21 Thread Richard Biener
On Sun, Jan 21, 2024 at 2:33 PM Hans-Peter Nilsson wrote: > > Tested x86_64-linux-gnu. Ok to commit? > > Or, does the message need more tweaking? > (If so, suggestions from native speakers?) > FWIW, I found no PR for just the message being bad. > > -- >8 -- > When you're not regularly exposed to

[PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'

2024-01-21 Thread Hans-Peter Nilsson
Tested x86_64-linux-gnu. Ok to commit? Or, does the message need more tweaking? (If so, suggestions from native speakers?) FWIW, I found no PR for just the message being bad. -- >8 -- When you're not regularly exposed to this warning, it is easy to be misled by its wording, believing that there'