Re: [PATCH] c/101512 - fix missing address-taking in c_common_mark_addressable_vec

2021-07-28 Thread Richard Biener
On Wed, 28 Jul 2021, Joseph Myers wrote: > On Wed, 21 Jul 2021, Jakub Jelinek via Gcc-patches wrote: > > > I wonder if instead when trying to wrap > > C_MAYBE_CONST_EXPR into a VIEW_CONVERT_EXPR we shouldn't be > > removing that C_MAYBE_CONST_EXPR and perhaps adding it around the > > VIEW_CONVERT

Re: [PATCH] c/101512 - fix missing address-taking in c_common_mark_addressable_vec

2021-07-28 Thread Joseph Myers
On Wed, 21 Jul 2021, Jakub Jelinek via Gcc-patches wrote: > I wonder if instead when trying to wrap > C_MAYBE_CONST_EXPR into a VIEW_CONVERT_EXPR we shouldn't be > removing that C_MAYBE_CONST_EXPR and perhaps adding it around the > VIEW_CONVERT_EXPR. E.g. various routines in c/c-typeck.c like > b

Re: [PATCH] c/101512 - fix missing address-taking in c_common_mark_addressable_vec

2021-07-28 Thread Richard Biener
On Wed, 21 Jul 2021, Jakub Jelinek wrote: > On Wed, Jul 21, 2021 at 10:06:51AM +0200, Richard Biener wrote: > > c_common_mark_addressable_vec fails to look through C_MAYBE_CONST_EXPR > > in the case it isn't at the toplevel. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? > > >

Re: [PATCH] c/101512 - fix missing address-taking in c_common_mark_addressable_vec

2021-07-21 Thread Jakub Jelinek via Gcc-patches
On Wed, Jul 21, 2021 at 10:06:51AM +0200, Richard Biener wrote: > c_common_mark_addressable_vec fails to look through C_MAYBE_CONST_EXPR > in the case it isn't at the toplevel. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? > > Thanks, > Richard. > > 2021-07-21 Richard Biener >

[PATCH] c/101512 - fix missing address-taking in c_common_mark_addressable_vec

2021-07-21 Thread Richard Biener
c_common_mark_addressable_vec fails to look through C_MAYBE_CONST_EXPR in the case it isn't at the toplevel. Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? Thanks, Richard. 2021-07-21 Richard Biener PR c/101512 gcc/c-family/ * c-common.c (c_common_mark_addressable_v