Re: [PATCH] c++: non-dependent assignment checking [PR63198, PR18474]

2023-09-18 Thread Jason Merrill via Gcc-patches
lly was added in https://gcc.gnu.org/pipermail/gcc-patches/2004-July/144621.html to suppress -Wparentheses warnings for non-templated compound assignment operator expressions. Here's a patch that also gets rid of that suppress_warning call: OK. -- >8 -- Subject: [PATCH] c++: non-dependen

Re: [PATCH] c++: non-dependent assignment checking [PR63198, PR18474]

2023-09-18 Thread Patrick Palka via Gcc-patches
(loc, lhs, modifycode, rhs, complain); > > + else > > +rval = build_new_op (loc, MODIFY_EXPR, LOOKUP_NORMAL, > > lhs, rhs, op, lookups, &overload, complain); > > - if (rval) > > - { > > if (rval == error_mark_node) > &

Re: [PATCH] c++: non-dependent assignment checking [PR63198, PR18474]

2023-09-17 Thread Jason Merrill via Gcc-patches
On 9/17/23 14:51, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? Patch generatde with -w to avoid noisy whitespace changes. -- >8 -- This patch makes us recognize and check non-dependent simple assigments ahead of time, like we already do f

[PATCH] c++: non-dependent assignment checking [PR63198, PR18474]

2023-09-17 Thread Patrick Palka via Gcc-patches
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? Patch generatde with -w to avoid noisy whitespace changes. -- >8 -- This patch makes us recognize and check non-dependent simple assigments ahead of time, like we already do for compound assignments. This means the