Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-07 Thread Jason Merrill via Gcc-patches
On 2/7/22 12:34, Patrick Palka wrote: On Thu, 3 Feb 2022, Jason Merrill wrote: On 2/3/22 15:55, Patrick Palka wrote: On Thu, Feb 3, 2022 at 3:20 PM Jason Merrill wrote: On 2/3/22 12:04, Patrick Palka wrote: On Wed, 2 Feb 2022, Jason Merrill wrote: On 2/2/22 12:09, Patrick Palka wrote: T

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-07 Thread Patrick Palka via Gcc-patches
On Thu, 3 Feb 2022, Jason Merrill wrote: > On 2/3/22 15:55, Patrick Palka wrote: > > On Thu, Feb 3, 2022 at 3:20 PM Jason Merrill wrote: > > > > > > On 2/3/22 12:04, Patrick Palka wrote: > > > > On Wed, 2 Feb 2022, Jason Merrill wrote: > > > > > > > > > On 2/2/22 12:09, Patrick Palka wrote: > >

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-03 Thread Jason Merrill via Gcc-patches
better. -- >8 -- Subject: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706] Here when expanding the pack expansion pattern, the template argument for T is an ARGUMENT_PACK_SELECT, which during satisfaction of C the satisfaction cache passes to iterative_has

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-03 Thread Patrick Palka via Gcc-patches
appens. So we didn't get a chance to unwrap the ARGUMENT_PACK_SELECT arguments yet, which IIUC happens transparently during substitution. > > I should have commented the gcc_unreachables better. > > > -- >8 -- > > > > Subject: [PATCH] c++: lambda in pack expansion us

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-03 Thread Jason Merrill via Gcc-patches
have commented the gcc_unreachables better. -- >8 -- Subject: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706] Here when expanding the pack expansion pattern, the template argument for T is an ARGUMENT_PACK_SELECT, which during satisfaction of C the sati

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-03 Thread Patrick Palka via Gcc-patches
l it was removed in r7-2082. -- >8 -- Subject: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706] Here when expanding the pack expansion pattern, the template argument for T is an ARGUMENT_PACK_SELECT, which during satisfaction of C the satisfaction cache pas

Re: [PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-02 Thread Jason Merrill via Gcc-patches
On 2/2/22 12:09, Patrick Palka wrote: The satisfaction cache needs to look through ARGUMENT_PACK_SELECT template arguments before calling iterative_hash_template_arg and template_args_equal, which would otherwise crash. Maybe we should handle ARGUMENT_PACK_SELECT in iterative_hash_template_arg

[PATCH] c++: lambda in pack expansion using outer pack in constraint [PR103706]

2022-02-02 Thread Patrick Palka via Gcc-patches
The satisfaction cache needs to look through ARGUMENT_PACK_SELECT template arguments before calling iterative_hash_template_arg and template_args_equal, which would otherwise crash. Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk and perhaps 11? PR c++/10370