Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-22 Thread Jason Merrill
On 9/21/23 11:53, Jason Merrill wrote: On 9/20/23 10:13, Patrick Palka wrote: On Tue, 19 Sep 2023, Patrick Palka wrote: On Tue, 19 Sep 2023, Jason Merrill wrote: On 9/19/23 12:40, Patrick Palka wrote: Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? OK for trunk.  What's you

Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-21 Thread Jason Merrill
On 9/20/23 10:13, Patrick Palka wrote: On Tue, 19 Sep 2023, Patrick Palka wrote: On Tue, 19 Sep 2023, Jason Merrill wrote: On 9/19/23 12:40, Patrick Palka wrote: Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? OK for trunk. What's your argument for backporting? Thanks. I

Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-20 Thread Patrick Palka
On Tue, 19 Sep 2023, Patrick Palka wrote: > On Tue, 19 Sep 2023, Jason Merrill wrote: > > > On 9/19/23 12:40, Patrick Palka wrote: > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? > > > > OK for trunk. What's your argument for backporting? > > Thanks. I don't feel strongly

Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-19 Thread Patrick Palka
On Tue, 19 Sep 2023, Jason Merrill wrote: > On 9/19/23 12:40, Patrick Palka wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? > > OK for trunk. What's your argument for backporting? Thanks. I don't feel strongly about it, but I was thinking that since we typically backp

Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-19 Thread Jason Merrill
On 9/19/23 12:40, Patrick Palka wrote: Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? OK for trunk. What's your argument for backporting? -- >8 -- 1. Move class NTTP object pretty printing to a more general spot in the pretty printer. 2. Print the type of an class NTTP o

[PATCH] c++: improve class NTTP object pretty printing [PR111471]

2023-09-19 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13? -- >8 -- 1. Move class NTTP object pretty printing to a more general spot in the pretty printer. 2. Print the type of an class NTTP object alongside its CONSTRUCTOR value, like dump_expr would have done. 3. Don't pretty print co