Re: [PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-29 Thread Bernhard Reutner-Fischer
On 29 January 2025 20:43:12 CET, Bernhard Reutner-Fischer wrote: > >>> deduction_guide_p doesn't look like a significant expense to me; I wouldn't >>> bother trying to optimize it without profile data as evidence. >> >>Yep, can confirm that it's insignificant. And DECL_FRIEND_CONTEXT isn't >>use

Re: [PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-29 Thread Bernhard Reutner-Fischer
>> deduction_guide_p doesn't look like a significant expense to me; I wouldn't >> bother trying to optimize it without profile data as evidence. > >Yep, can confirm that it's insignificant. And DECL_FRIEND_CONTEXT isn't >used in any particularly hot code so the implied memory barrier of the >ded

Re: [PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-28 Thread Patrick Palka
On Mon, 27 Jan 2025, Jason Merrill wrote: > On 1/27/25 4:17 PM, Patrick Palka wrote: > > On Mon, 27 Jan 2025, Patrick Palka wrote: > > > > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > > > OK for trunk/14? > > OK. Thanks, pushed. > > > > +&& (cxx_dialect < cxx23 ||

Re: [PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-27 Thread Jason Merrill
On 1/27/25 4:17 PM, Patrick Palka wrote: On Mon, 27 Jan 2025, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk/14? OK. +&& (cxx_dialect < cxx23 || !deduction_guide_p (NODE))) \ N.B. I decided to check cxx_dialect here since deduction

Re: [PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-27 Thread Patrick Palka
On Mon, 27 Jan 2025, Patrick Palka wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > OK for trunk/14? > > -- >8 -- > > We recently started using the lang_decl_fn::context field to track > inheritedness of a deduction guide (for C++23 inherited CTAD). This > new overlo

[PATCH] c++: friend vs inherited guide confusion [PR117855]

2025-01-27 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk/14? -- >8 -- We recently started using the lang_decl_fn::context field to track inheritedness of a deduction guide (for C++23 inherited CTAD). This new overloading of the field accidentally made DECL_FRIEND_CONTEXT re