On 5/25/22 14:49, Marek Polacek wrote:
On Tue, May 24, 2022 at 08:22:22AM -0400, Jason Merrill wrote:
On 4/29/22 10:12, Marek Polacek wrote:
This patch fixes crashes with invalid attributes. Arguably it could
make sense to assert seen_error() too.
So in this testcase we have TREE_CHAIN of a
On Tue, May 24, 2022 at 08:22:22AM -0400, Jason Merrill wrote:
> On 4/29/22 10:12, Marek Polacek wrote:
> > This patch fixes crashes with invalid attributes. Arguably it could
> > make sense to assert seen_error() too.
>
> So in this testcase we have TREE_CHAIN of a TREE_LIST pointing to
> error_
On Tue, May 24, 2022 at 05:29:56PM +0530, Prathamesh Kulkarni wrote:
> On Fri, 29 Apr 2022 at 19:44, Marek Polacek via Gcc-patches
> wrote:
> >
> > This patch fixes crashes with invalid attributes. Arguably it could
> > make sense to assert seen_error() too.
> >
> > Bootstrapped/regtested on x86_
On 4/29/22 10:12, Marek Polacek wrote:
This patch fixes crashes with invalid attributes. Arguably it could
make sense to assert seen_error() too.
So in this testcase we have TREE_CHAIN of a TREE_LIST pointing to
error_mark_node? Can we avoid that?
Bootstrapped/regtested on x86_64-pc-linux
On Fri, 29 Apr 2022 at 19:44, Marek Polacek via Gcc-patches
wrote:
>
> This patch fixes crashes with invalid attributes. Arguably it could
> make sense to assert seen_error() too.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk = GCC 13?
>
> PR c++/96637
>
> gcc/ChangeLog:
Ping.
On Fri, Apr 29, 2022 at 10:12:33AM -0400, Marek Polacek via Gcc-patches wrote:
> This patch fixes crashes with invalid attributes. Arguably it could
> make sense to assert seen_error() too.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk = GCC 13?
>
> PR c++/96637
>
This patch fixes crashes with invalid attributes. Arguably it could
make sense to assert seen_error() too.
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk = GCC 13?
PR c++/96637
gcc/ChangeLog:
* attribs.cc (decl_attributes): Check error_mark_node.
gcc/cp/ChangeLog:
