Re: [PATCH] c++: error message for dependent template members [PR70417]

2022-01-17 Thread Jason Merrill via Gcc-patches
On Sat, Jan 15, 2022 at 3:28 AM Anthony Sharp wrote: > Hi Jason, > > Hope you are well. Apologies, I've not had time to sit down and look at > this since last month I quit my old job, then I had family around for the > whole of the Christmas period, and then even more recently I've had to > start

Re: [PATCH] c++: error message for dependent template members [PR70417]

2022-01-15 Thread Anthony Sharp via Gcc-patches
Hi Jason, Hope you are well. Apologies, I've not had time to sit down and look at this since last month I quit my old job, then I had family around for the whole of the Christmas period, and then even more recently I've had to start my new job. In any case happy that you managed to figure it all

Re: [PATCH] c++: error message for dependent template members [PR70417]

2022-01-13 Thread Jason Merrill via Gcc-patches
On 12/9/21 10:51, Jason Merrill wrote: On 12/4/21 12:23, Anthony Sharp wrote: Hi Jason, Hope you are well. Apologies for not coming back sooner.  >I'd put it just above the definition of saved_token_sentinel in parser.c. Sounds good, done.  >Maybe cp_parser_require_end_of_template_paramete

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-12-09 Thread Jason Merrill via Gcc-patches
On 12/4/21 12:23, Anthony Sharp wrote: Hi Jason, Hope you are well. Apologies for not coming back sooner. >I'd put it just above the definition of saved_token_sentinel in parser.c. Sounds good, done. >Maybe cp_parser_require_end_of_template_parameter_list?  Either way is fine. Even bette

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-12-04 Thread Anthony Sharp via Gcc-patches
Hi Jason, Hope you are well. Apologies for not coming back sooner. >I'd put it just above the definition of saved_token_sentinel in parser.c. Sounds good, done. >Maybe cp_parser_require_end_of_template_parameter_list? Either way is fine. Even better, have changed it. >Hmm, good point; operat

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-10-19 Thread Jason Merrill via Gcc-patches
On 10/10/21 07:28, Anthony Sharp wrote: Hi Jason, Hope you are well. Thanks for the feedback. I like adding the configurability, but I think let's keep committing as the default behavior.  And adding the parameter to the rollback function seems unnecessary.  For the behavior argumen

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-10-10 Thread Anthony Sharp via Gcc-patches
hours even with -j 12. Maybe I ought to think about getting a dedicated Linux PC. Patch should be attached. Kind regards, Anthony On Wed, 22 Sept 2021 at 21:04, Jason Merrill wrote: > On 9/17/21 18:22, Anthony Sharp wrote: > > And also re-attaching the patch! > > > > On Fri, 17 Sept 2021

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-09-22 Thread Jason Merrill via Gcc-patches
for dependent template members [PR70417] To: Jason Merrill Hi Jason! Apologies for the delay. This is basically core issue 1835, http://wg21.link/cwg1835 This was changed for C++23 by the paper "Declarations and where to find them", http://wg21.link/p1787 Interesting, I was no

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-09-17 Thread Anthony Sharp via Gcc-patches
And also re-attaching the patch! On Fri, 17 Sept 2021 at 23:17, Anthony Sharp wrote: > > Re-adding gcc-patches@gcc.gnu.org. > > -- Forwarded message - > From: Anthony Sharp > Date: Fri, 17 Sept 2021 at 23:11 > Subject: Re: [PATCH] c++: error message f

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-09-17 Thread Anthony Sharp via Gcc-patches
Re-adding gcc-patches@gcc.gnu.org. -- Forwarded message - From: Anthony Sharp Date: Fri, 17 Sept 2021 at 23:11 Subject: Re: [PATCH] c++: error message for dependent template members [PR70417] To: Jason Merrill Hi Jason! Apologies for the delay. > This is basically core is

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-08-27 Thread Jason Merrill via Gcc-patches
On 8/20/21 12:56 PM, Anthony Sharp via Gcc-patches wrote: Hi, hope everyone is well. I have a patch here for issue 70417 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70417). I'm still a GCC noob, and this is probably the hardest thing I have ever coded in my life, so please forgive any initial m

[PATCH] c++: error message for dependent template members [PR70417]

2021-08-20 Thread Anthony Sharp via Gcc-patches
performance improvement - I don't really have the high-level experience to be able to judge whether that is worth the increased code complexity or not, so I just went with my gut. Please find patch attached :) Kind regards, Anthony Sharp From 0316e821607f6875293a664ab181747188ef3e73 Mon Sep 1