Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-06 Thread Marek Polacek via Gcc-patches
On Sat, Feb 04, 2023 at 06:02:46PM -0800, Jason Merrill via Gcc-patches wrote: > On 2/4/23 20:41, Jason Merrill wrote: > > On 2/4/23 20:08, Patrick Palka wrote: > > > On Sat, 4 Feb 2023, Jason Merrill wrote: > > > > > diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc > > > > > index 255332dc0c1..c9360240cd2

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-05 Thread Jason Merrill via Gcc-patches
ly regtested so far. Full bootstrap and regtest running on x86_64-pc-linux-gnu. -- >8 -- Subject: [PATCH] c++: equivalence of non-dependent calls [PR107461] After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTI

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-05 Thread Patrick Palka via Gcc-patches
emplate_arg (tree arg, hashval_t > > > > > val) > > > > >    case CALL_EXPR: > > > > > { > > > > >    tree fn = CALL_EXPR_FN (arg); > > > > > +    if (TREE_TYPE (arg) == NULL_TREE) > > > > > >

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-04 Thread Jason Merrill via Gcc-patches
On 2/4/23 20:41, Jason Merrill wrote: On 2/4/23 20:08, Patrick Palka wrote: On Sat, 4 Feb 2023, Jason Merrill wrote: On 2/4/23 15:31, Patrick Palka wrote: After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-04 Thread Jason Merrill via Gcc-patches
On 2/4/23 20:08, Patrick Palka wrote: On Sat, 4 Feb 2023, Jason Merrill wrote: On 2/4/23 15:31, Patrick Palka wrote: After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION_DECL. This innocent change revealed tha

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-04 Thread Patrick Palka via Gcc-patches
On Sat, 4 Feb 2023, Jason Merrill wrote: > On 2/4/23 15:31, Patrick Palka wrote: > > After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent > > CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION_DECL. > > This innocent change revealed that cp_tree_equal doesn't firs

Re: [PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-04 Thread Jason Merrill via Gcc-patches
On 2/4/23 15:31, Patrick Palka wrote: After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION_DECL. This innocent change revealed that cp_tree_equal doesn't first check dependentness of a CALL_EXPR before treating t

[PATCH] c++: equivalence of non-dependent calls [PR107461]

2023-02-04 Thread Patrick Palka via Gcc-patches
After r13-5684-g59e0376f607805 the (pruned) callee of a non-dependent CALL_EXPR is a bare FUNCTION_DECL rather than ADDR_EXPR of FUNCTION_DECL. This innocent change revealed that cp_tree_equal doesn't first check dependentness of a CALL_EXPR before treating the callee as a dependent name, which man