Re: [PATCH] c++: devirtualization of array destruction [PR110057]

2023-07-28 Thread Jason Merrill via Gcc-patches
erify Thanks! Thanks. I added a comment and fixed another test that was breaking with the patch; here's what I pushed. JasonFrom a47e615fbf9c6f4b24e5032df5d720b6bf9b63b5 Mon Sep 17 00:00:00 2001 From: Ng YongXiang Date: Thu, 27 Jul 2023 08:06:14 +0800 Subject: [PATCH] c++: devirtual

Re: [PATCH] c++: devirtualization of array destruction [PR110057]

2023-07-26 Thread Ng YongXiang via Gcc-patches
od to have a > > // PR c++/110057 > > line at the top of the testcase for future reference. gcc-commit-mklog > also uses that to add the PR number to the ChangeLog. > > Jason > > From 04e9b412e49a3966f84edd3afda66ebdb729efdc Mon Sep 17 00:00:00 2001 From: yongxiangng D

Re: [PATCH] c++: devirtualization of array destruction [PR110057]

2023-07-26 Thread Jason Merrill via Gcc-patches
On 7/26/23 12:00, Ng YongXiang wrote: Hi Jason, Thanks for the reply and review. I've attached an updated patch with the change log and sign off. The change made in gcc/testsuite/g++.dg/warn/pr83054.C is because I think there is no more warning since we have already devirtualized the destru

[PATCH] c++: devirtualization of array destruction [PR110057]

2023-07-26 Thread Ng YongXiang via Gcc-patches
j = 0; j < 3; j++) > > - { > > - printf("&a[%d][%d] = %x\n", i, j, (void *)&array[i][j]); > > - } > > - } > > - // The count should be nine, if not, fail the test. > > - if (foo::count != 9) > > - return 1; > > - } >