Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Jason Merrill via Gcc-patches
On 1/22/21 4:45 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Jason Merrill wrote: On 1/22/21 1:58 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Jason Merrill wrote: On 1/22/21 12:59 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrot

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Patrick Palka via Gcc-patches
On Fri, 22 Jan 2021, Jason Merrill wrote: > On 1/22/21 1:58 PM, Patrick Palka wrote: > > On Fri, 22 Jan 2021, Jason Merrill wrote: > > > > > On 1/22/21 12:59 PM, Patrick Palka wrote: > > > > On Fri, 22 Jan 2021, Patrick Palka wrote: > > > > > > > > > On Fri, 22 Jan 2021, Patrick Palka wrote: > >

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Jason Merrill via Gcc-patches
On 1/22/21 1:58 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Jason Merrill wrote: On 1/22/21 12:59 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrote: On Thu, 21 Jan 2021, Jason Merrill wrote: On 1/21/21 11:22 AM, Patrick Palka wr

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Patrick Palka via Gcc-patches
On Fri, 22 Jan 2021, Jason Merrill wrote: > On 1/22/21 12:59 PM, Patrick Palka wrote: > > On Fri, 22 Jan 2021, Patrick Palka wrote: > > > > > On Fri, 22 Jan 2021, Patrick Palka wrote: > > > > > > > On Thu, 21 Jan 2021, Jason Merrill wrote: > > > > > > > > > On 1/21/21 11:22 AM, Patrick Palka wr

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Jason Merrill via Gcc-patches
On 1/22/21 12:59 PM, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrote: On Fri, 22 Jan 2021, Patrick Palka wrote: On Thu, 21 Jan 2021, Jason Merrill wrote: On 1/21/21 11:22 AM, Patrick Palka wrote: Here at parse time finish_qualified_id_expr adds an implicit 'this->' to the exp

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Patrick Palka via Gcc-patches
On Fri, 22 Jan 2021, Patrick Palka wrote: > On Fri, 22 Jan 2021, Patrick Palka wrote: > > > On Thu, 21 Jan 2021, Jason Merrill wrote: > > > > > On 1/21/21 11:22 AM, Patrick Palka wrote: > > > > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > > > > the expression tmp::i

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Patrick Palka via Gcc-patches
On Fri, 22 Jan 2021, Patrick Palka wrote: > On Thu, 21 Jan 2021, Jason Merrill wrote: > > > On 1/21/21 11:22 AM, Patrick Palka wrote: > > > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > > > the expression tmp::integral (because it's type-dependent, and also > > > curr

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-22 Thread Patrick Palka via Gcc-patches
On Thu, 21 Jan 2021, Jason Merrill wrote: > On 1/21/21 11:22 AM, Patrick Palka wrote: > > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > > the expression tmp::integral (because it's type-dependent, and also > > current_class_ptr is set) within the trailing return type,

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Jason Merrill via Gcc-patches
On 1/21/21 11:22 AM, Patrick Palka wrote: Here at parse time finish_qualified_id_expr adds an implicit 'this->' to the expression tmp::integral (because it's type-dependent, and also current_class_ptr is set) within the trailing return type, and later during substitution we can't resolve the 'thi

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
hich also addresses a minor diagnostic regression in a gomp testcase that I didn't notice earlier: -- >8 -- Subject: [PATCH] c++: Suppress 'this' injection for static member functions [PR97399] In the testcase pr97399a.C below, finish_qualified_id_expr at parse time adds an impl

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Marek Polacek via Gcc-patches
On Thu, Jan 21, 2021 at 11:22:24AM -0500, Patrick Palka via Gcc-patches wrote: > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > the expression tmp::integral (because it's type-dependent, and also > current_class_ptr is set) within the trailing return type, and later > du

Re: [PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
On Thu, 21 Jan 2021, Patrick Palka wrote: > Here at parse time finish_qualified_id_expr adds an implicit 'this->' to > the expression tmp::integral (because it's type-dependent, and also > current_class_ptr is set) within the trailing return type, and later > during substitution we can't resolve t

[PATCH] c++: Suppress this injection for static member functions [PR97399]

2021-01-21 Thread Patrick Palka via Gcc-patches
Here at parse time finish_qualified_id_expr adds an implicit 'this->' to the expression tmp::integral (because it's type-dependent, and also current_class_ptr is set) within the trailing return type, and later during substitution we can't resolve the 'this' since tsubst_function_type does inject_th