Re: [PATCH] c++: Some improvements to concept diagnostics

2020-02-25 Thread Jason Merrill
On 2/24/20 12:30 PM, Patrick Palka wrote: On Mon, 24 Feb 2020, Jason Merrill wrote: On 2/20/20 7:27 PM, Patrick Palka wrote: This patch improves our concept diagnostics in two ways. First, it sets a more precise location for the constraint expressions built in finish_constraint_binary_op. As

Re: [PATCH] c++: Some improvements to concept diagnostics

2020-02-24 Thread Patrick Palka
On Mon, 24 Feb 2020, Jason Merrill wrote: > On 2/20/20 7:27 PM, Patrick Palka wrote: > > This patch improves our concept diagnostics in two ways. First, it sets a > > more > > precise location for the constraint expressions built in > > finish_constraint_binary_op. As a result, when a disjunctio

Re: [PATCH] c++: Some improvements to concept diagnostics

2020-02-24 Thread Jason Merrill
On 2/20/20 7:27 PM, Patrick Palka wrote: This patch improves our concept diagnostics in two ways. First, it sets a more precise location for the constraint expressions built in finish_constraint_binary_op. As a result, when a disjunction is unsatisfied we now print e.g. .../include/bits/range_

[PATCH] c++: Some improvements to concept diagnostics

2020-02-20 Thread Patrick Palka
This patch improves our concept diagnostics in two ways. First, it sets a more precise location for the constraint expressions built in finish_constraint_binary_op. As a result, when a disjunction is unsatisfied we now print e.g. .../include/bits/range_access.h:467:2: note: neither operand of th