Re: [PATCH] c++: Restore rust front-end build [PR117114]

2024-10-15 Thread Simon Martin
Hi Jason, On 15 Oct 2024, at 15:18, Jason Merrill wrote: > On 10/13/24 7:55 AM, Simon Martin wrote: >> The patch that I merged via r15-4282-g60163c85730e6b breaks the build >> for the rust front-end because it does not work well when virtual >> inheritance is in play. >> >> The problem is that in

Re: [PATCH] c++: Restore rust front-end build [PR117114]

2024-10-15 Thread Jason Merrill
On 10/13/24 7:55 AM, Simon Martin wrote: The patch that I merged via r15-4282-g60163c85730e6b breaks the build for the rust front-end because it does not work well when virtual inheritance is in play. The problem is that in such a case, an overrider and its overridden base method might have a di

Re: [PATCH] c++: Restore rust front-end build [PR117114]

2024-10-13 Thread Simon Martin
The patch failed so I’ve reverted the offending commit for the moment; commit r15-4301-ga4eec6c712ec16 refers. I’ll work on a resubmit via the initial PR (109918). Apologies for the breakage. Simon On 13 Oct 2024, at 13:55, Simon Martin wrote: > The patch that I merged via r15-4282-g60163c8573

[PATCH] c++: Restore rust front-end build [PR117114]

2024-10-13 Thread Simon Martin
The patch that I merged via r15-4282-g60163c85730e6b breaks the build for the rust front-end because it does not work well when virtual inheritance is in play. The problem is that in such a case, an overrider and its overridden base method might have a different DECL_VINDEX, and the derived method