Re: [PATCH] c++: Don't show constructor internal name in error message [PR105483]

2024-08-27 Thread Jason Merrill
On 8/27/24 1:15 PM, Simon Martin wrote: Hi Jason, On 26 Aug 2024, at 19:30, Jason Merrill wrote: On 8/26/24 12:49 PM, Simon Martin wrote: We mention 'X::__ct' instead of 'X::X' in the "names the constructor, not the type" error for this invalid code: === cut here === struct X {}; void g (

Re: [PATCH] c++: Don't show constructor internal name in error message [PR105483]

2024-08-27 Thread Simon Martin
, because we’d miss genuine errors emitted by cp_parser_consume_semicolon_at_end_of_statement (e.g. break the c-c++-common/pr44515.c test, among others), however the updated patch does what you’re suggesting. I have successfully tested on x86_64-pc-linux-gnu. OK for trunk? Thanks! Simon &

Re: [PATCH] c++: Don't show constructor internal name in error message [PR105483]

2024-08-26 Thread Jason Merrill
On 8/26/24 12:49 PM, Simon Martin wrote: We mention 'X::__ct' instead of 'X::X' in the "names the constructor, not the type" error for this invalid code: === cut here === struct X {}; void g () { X::X x; } === cut here === The problem is that we use %<%T::%D%> to build the error message, whi

[PATCH] c++: Don't show constructor internal name in error message [PR105483]

2024-08-26 Thread Simon Martin
We mention 'X::__ct' instead of 'X::X' in the "names the constructor, not the type" error for this invalid code: === cut here === struct X {}; void g () { X::X x; } === cut here === The problem is that we use %<%T::%D%> to build the error message, while %qE does exactly what we need since we ha