Re: [PATCH] c++: Distinguish unsatisfaction vs errors during satisfaction [PR97093]

2020-12-04 Thread Patrick Palka via Gcc-patches
On Thu, 3 Dec 2020, Jason Merrill wrote: > On 12/3/20 9:24 AM, Patrick Palka wrote: > > During satisfaction, the flag info.noisy() controls three things: > > whether to diagnose fatal errors (such as the satisfaction value of an > > atom being non-bool); whether to diagnose unsatisfaction; and whe

Re: [PATCH] c++: Distinguish unsatisfaction vs errors during satisfaction [PR97093]

2020-12-03 Thread Jason Merrill via Gcc-patches
On 12/3/20 9:24 AM, Patrick Palka wrote: During satisfaction, the flag info.noisy() controls three things: whether to diagnose fatal errors (such as the satisfaction value of an atom being non-bool); whether to diagnose unsatisfaction; and whether to bypass the satisfaction cache. This flag turn

[PATCH] c++: Distinguish unsatisfaction vs errors during satisfaction [PR97093]

2020-12-03 Thread Patrick Palka via Gcc-patches
During satisfaction, the flag info.noisy() controls three things: whether to diagnose fatal errors (such as the satisfaction value of an atom being non-bool); whether to diagnose unsatisfaction; and whether to bypass the satisfaction cache. This flag turns out to be too coarse however, for sometim