Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-05-12 Thread Jason Merrill
On 5/11/25 7:11 PM, Owen Avery wrote: Yeah, that looks way simpler. Should I add you as co-author on the patch? Sounds good, thanks. On 4/28/25 22:13, Jason Merrill wrote: On 4/28/25 5:07 PM, Owen Avery wrote: As far as I can tell, that would need to be applied to every class which virtuall

Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-05-11 Thread Owen Avery
Yeah, that looks way simpler. Should I add you as co-author on the patch? On 4/28/25 22:13, Jason Merrill wrote: On 4/28/25 5:07 PM, Owen Avery wrote: As far as I can tell, that would need to be applied to every class which virtually inherits from such a base class, rather than just the base c

Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-04-28 Thread Jason Merrill
On 4/28/25 5:07 PM, Owen Avery wrote: As far as I can tell, that would need to be applied to every class which virtually inherits from such a base class, rather than just the base class's move assignment operator. Ah, sure. But if you replace the lookup_attribute with warning_enabled_at (DEC

Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-04-28 Thread Jason Merrill
On 4/27/25 5:57 PM, Owen Avery wrote: This patch should make it easier to selectively disable -Wvirtual-move-assign errors by adding an attribute for move assignment operators which marks them as handling duplicate calls. Thanks, but this sort of situation seems like a good fit for #pragma GCC

Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-04-27 Thread Sandra Loosemore
On 4/27/25 15:57, Owen Avery wrote: This patch should make it easier to selectively disable -Wvirtual-move-assign errors by adding an attribute for move assignment operators which marks them as handling duplicate calls. I'm only qualified to comment on the documentation part of the patch. dif

Re: [PATCH] c++: Add attribute handles_virtual_move_assign

2025-04-27 Thread Owen Avery
I'm open to renaming the attribute and/or test file, of course.

[PATCH] c++: Add attribute handles_virtual_move_assign

2025-04-27 Thread Owen Avery
This patch should make it easier to selectively disable -Wvirtual-move-assign errors by adding an attribute for move assignment operators which marks them as handling duplicate calls. gcc/cp/ChangeLog: * method.cc: Include "attribs.h". (synthesized_method_walk): Avoid outputting