Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-22 Thread Jason Merrill
On 01/20/2016 06:04 PM, Martin Sebor wrote: Right. The problem is this code in is_late_template_attribute: /* If the first attribute argument is an identifier, only consider second and following arguments. Attributes like mode, format, cleanup and several target specif

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-20 Thread Martin Sebor
Right. The problem is this code in is_late_template_attribute: /* If the first attribute argument is an identifier, only consider second and following arguments. Attributes like mode, format, cleanup and several target specific attributes aren't late just becau

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-18 Thread Jason Merrill
On 01/12/2016 01:11 PM, Martin Sebor wrote: On 01/11/2016 10:20 PM, Jason Merrill wrote: On 12/22/2015 09:32 PM, Martin Sebor wrote: + if (is_attribute_p ("aligned", name) + || is_attribute_p ("vector_size", name)) +{ + /* Attribute argument may be a dependent indentifier. */ +

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-15 Thread Martin Sebor
On 01/12/2016 11:11 AM, Martin Sebor wrote: On 01/11/2016 10:20 PM, Jason Merrill wrote: On 12/22/2015 09:32 PM, Martin Sebor wrote: + if (is_attribute_p ("aligned", name) + || is_attribute_p ("vector_size", name)) +{ + /* Attribute argument may be a dependent indentifier. */ +

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-12 Thread Martin Sebor
On 01/11/2016 10:20 PM, Jason Merrill wrote: On 12/22/2015 09:32 PM, Martin Sebor wrote: + if (is_attribute_p ("aligned", name) + || is_attribute_p ("vector_size", name)) +{ + /* Attribute argument may be a dependent indentifier. */ + if (tree t = args ? TREE_VALUE (args) :

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-11 Thread Jason Merrill
On 12/22/2015 09:32 PM, Martin Sebor wrote: + if (is_attribute_p ("aligned", name) + || is_attribute_p ("vector_size", name)) +{ + /* Attribute argument may be a dependent indentifier. */ + if (tree t = args ? TREE_VALUE (args) : NULL_TREE) + if (value_dependent_express

PING #2 [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02074.html On 01/04/2016 09:49 PM, Martin Sebor wrote: Ping: looking for review/approval of the patch below: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02074.html Thanks Martin On 12/22/2015 07:32 PM, Martin Sebor wrote: The attach

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-04 Thread Martin Sebor
Ping: looking for review/approval of the patch below: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02074.html Thanks Martin On 12/22/2015 07:32 PM, Martin Sebor wrote: The attached patch adds handling of dependent arguments to attribute aligned and attribute vector_size, fixing c++/58109 and

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2015-12-22 Thread Marc Glisse
On Tue, 22 Dec 2015, Martin Sebor wrote: The attached patch adds handling of dependent arguments to attribute aligned and attribute vector_size, fixing c++/58109 and 69022 - attribute vector_size ignored with dependent bytes. In the longer term, Gaby used to suggest that internally we should

[PATCH] c++/58109 - alignas() fails to compile with constant expression

2015-12-22 Thread Martin Sebor
The attached patch adds handling of dependent arguments to attribute aligned and attribute vector_size, fixing c++/58109 and 69022 - attribute vector_size ignored with dependent bytes. Tested on x86_64. Martin gcc/testsuite/ChangeLog: 2015-12-22 Martin Sebor PR c++/58109 PR c++/69022 * g+