Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-15 Thread Iain Sandoe
> On 10 Dec 2024, at 01:02, Jason Merrill wrote: > > On 12/9/24 2:39 PM, Iain Sandoe wrote: >>> On 9 Dec 2024, at 19:34, Jason Merrill wrote: >>> >>> On 12/9/24 2:00 PM, Iain Sandoe wrote: > On 9 Dec 2024, at 18:56, Jason Merrill wrote: > > On 11/29/24 8:47 AM, Iain Sandoe wrote

Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-09 Thread Jason Merrill
On 12/9/24 2:39 PM, Iain Sandoe wrote: On 9 Dec 2024, at 19:34, Jason Merrill wrote: On 12/9/24 2:00 PM, Iain Sandoe wrote: On 9 Dec 2024, at 18:56, Jason Merrill wrote: On 11/29/24 8:47 AM, Iain Sandoe wrote: Tested on x86_64-darwin, x86_64-linux, OK for trunk? thanks Iain --- 8< --- At

Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-09 Thread Iain Sandoe
> On 9 Dec 2024, at 19:34, Jason Merrill wrote: > > On 12/9/24 2:00 PM, Iain Sandoe wrote: >>> On 9 Dec 2024, at 18:56, Jason Merrill wrote: >>> >>> On 11/29/24 8:47 AM, Iain Sandoe wrote: Tested on x86_64-darwin, x86_64-linux, OK for trunk? thanks Iain --- 8< --- >>

Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-09 Thread Jason Merrill
On 12/9/24 2:00 PM, Iain Sandoe wrote: On 9 Dec 2024, at 18:56, Jason Merrill wrote: On 11/29/24 8:47 AM, Iain Sandoe wrote: Tested on x86_64-darwin, x86_64-linux, OK for trunk? thanks Iain --- 8< --- At present, we only update the suspend index when we actually are at the stage that the co

Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-09 Thread Iain Sandoe
> On 9 Dec 2024, at 18:56, Jason Merrill wrote: > > On 11/29/24 8:47 AM, Iain Sandoe wrote: >> Tested on x86_64-darwin, x86_64-linux, >> OK for trunk? >> thanks >> Iain >> --- 8< --- >> At present, we only update the suspend index when we actually are >> at the stage that the coroutine is cons

Re: [PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-12-09 Thread Jason Merrill
On 11/29/24 8:47 AM, Iain Sandoe wrote: Tested on x86_64-darwin, x86_64-linux, OK for trunk? thanks Iain --- 8< --- At present, we only update the suspend index when we actually are at the stage that the coroutine is considered suspended. This is on the basis that it is UB to resume or destroy

[PATCH] c++, coroutines: Make suspend index consistent for debug.

2024-11-29 Thread Iain Sandoe
Tested on x86_64-darwin, x86_64-linux, OK for trunk? thanks Iain --- 8< --- At present, we only update the suspend index when we actually are at the stage that the coroutine is considered suspended. This is on the basis that it is UB to resume or destroy a coroutines that is not suspended (and th