Re: [PATCH] build: Fix missing variable quotes and typo

2024-06-19 Thread YunQiang Su
Collin Funk 于2024年6月20日周四 07:40写道: > > I've just fixed the quotes and that typo in one patch. I hope you don't > mind. When using Autoconf 2.69 and Automake 1.15.1 that copyright diff > goes away. I'm not familiar with the gcc-autoregen bot but I think this > should make it happy. > > -- >8 --

[PATCH] build: Fix missing variable quotes and typo

2024-06-19 Thread Collin Funk
I've just fixed the quotes and that typo in one patch. I hope you don't mind. When using Autoconf 2.69 and Automake 1.15.1 that copyright diff goes away. I'm not familiar with the gcc-autoregen bot but I think this should make it happy. -- >8 -- When dlopen and pthread_create are in libc the v

Re: [PATCH] build: Fix missing variable quotes

2024-06-18 Thread Richard Biener
On Tue, Jun 18, 2024 at 10:35 AM Sam James wrote: > > YunQiang Su writes: > > > OK for trunk? > > It looks good to me, but I can't approve. (I'd dare say it's obvious, > even.) > > Richard, any chance you could give it a quick ack? OK

Re: [PATCH] build: Fix missing variable quotes

2024-06-18 Thread Sam James
YunQiang Su writes: > OK for trunk? It looks good to me, but I can't approve. (I'd dare say it's obvious, even.) Richard, any chance you could give it a quick ack?

Re: [PATCH] build: Fix missing variable quotes

2024-06-18 Thread YunQiang Su
OK for trunk? -- YunQiang Su

Re: [PATCH] build: Fix missing variable quotes

2024-06-14 Thread YunQiang Su
Sam James 于2024年6月14日周五 09:02写道: > > Collin Funk writes: > > > When dlopen and pthread_create are in libc the variable is > > set to "none required", therefore running configure will show > > the following errors: > > > > ./configure: line 8997: test: too many arguments > > ./configure: line 8999

Re: [PATCH] build: Fix missing variable quotes

2024-06-14 Thread Arthur Cohen
Hi Collin, Sorry about the mess. As Sam pointed out, there was already a patch proposed in the bugzilla PR which I've posted on the ML as well for review. The only difference with your patch is that it also changes ac_cv_search_pthread_crate to ac_cv_search_pthread_create, as otherwise the ch

Re: [PATCH] build: Fix missing variable quotes

2024-06-13 Thread Sam James
Collin Funk writes: > When dlopen and pthread_create are in libc the variable is > set to "none required", therefore running configure will show > the following errors: > > ./configure: line 8997: test: too many arguments > ./configure: line 8999: test: too many arguments > ./configure: line 9003

[PATCH] build: Fix missing variable quotes

2024-06-13 Thread Collin Funk
When dlopen and pthread_create are in libc the variable is set to "none required", therefore running configure will show the following errors: ./configure: line 8997: test: too many arguments ./configure: line 8999: test: too many arguments ./configure: line 9003: test: too many arguments ./config