Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-09-08 Thread Segher Boessenkool
Hi! Sorry this took so long to come back to... On Tue, Aug 25, 2020 at 02:39:56PM -0600, Jeff Law wrote: > On Fri, 2020-08-07 at 21:51 +, Segher Boessenkool wrote: > > When the compgotos pass copies the tail of blocks ending in an indirect > > jump, there is a micro-optimization to not copy t

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-25 Thread Jeff Law via Gcc-patches
On Fri, 2020-08-07 at 21:51 +, Segher Boessenkool wrote: > When the compgotos pass copies the tail of blocks ending in an indirect > jump, there is a micro-optimization to not copy the last one, since the > original block will then just be deleted. This does not work properly > if cleanup_cfg

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-19 Thread Segher Boessenkool
Hi! On Wed, Aug 19, 2020 at 07:18:02PM +0100, Richard Sandiford wrote: > > I have never seen the second case misfiring in practice, only the first > > one! > > Shucks, I guessed the wrong way round :-) > > I'd argue that the first check isn't a micro-optimisation though. > It's testing whether t

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-19 Thread Richard Sandiford
Segher Boessenkool writes: > On Wed, Aug 19, 2020 at 01:10:36PM +0100, Richard Sandiford wrote: >> Segher Boessenkool writes: >> > When the compgotos pass copies the tail of blocks ending in an indirect >> > jump, there is a micro-optimization to not copy the last one, since the >> > original blo

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2020 at 01:10:36PM +0100, Richard Sandiford wrote: > Segher Boessenkool writes: > > When the compgotos pass copies the tail of blocks ending in an indirect > > jump, there is a micro-optimization to not copy the last one, since the > > original block will then just be deleted. Thi

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-19 Thread Richard Sandiford
Segher Boessenkool writes: > When the compgotos pass copies the tail of blocks ending in an indirect > jump, there is a micro-optimization to not copy the last one, since the > original block will then just be deleted. This does not work properly > if cleanup_cfg does not merge all pairs of block

Re: [PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-17 Thread Segher Boessenkool
Ping (added some Cc:s). Thanks in advance, Segher On Fri, Aug 07, 2020 at 09:51:04PM +, Segher Boessenkool wrote: > When the compgotos pass copies the tail of blocks ending in an indirect > jump, there is a micro-optimization to not copy the last one, since the > original block will then j

[PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-07 Thread Segher Boessenkool
When the compgotos pass copies the tail of blocks ending in an indirect jump, there is a micro-optimization to not copy the last one, since the original block will then just be deleted. This does not work properly if cleanup_cfg does not merge all pairs of blocks we expect it to. v2: This also d

[PATCH] bb-reorder: Remove a misfiring micro-optimization (PR96475)

2020-08-06 Thread Segher Boessenkool
When the compgotos pass copies the tail of blocks ending in an indirect jump, there is a micro-optimization to not copy the last one, since the original block will then just be deleted. This does not work properly if cleanup_cfg does not merge all pairs of blocks we expect it to. 2020-08-07 Segh