Re: [Ping] Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-17 Thread Jeff Law via Gcc-patches
On 6/16/23 04:17, SenthilKumar.Selvaraj--- via Gcc-patches wrote: On Fri, 2023-06-02 at 12:32 +0530, Senthil Kumar Selvaraj wrote: On Mon, 2023-05-22 at 14:05 +0200, Richard Biener wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Fri, May

[Ping] Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-16 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Fri, 2023-06-02 at 12:32 +0530, Senthil Kumar Selvaraj wrote: > On Mon, 2023-05-22 at 14:05 +0200, Richard Biener wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Fri, May 19, 2023 at 7:58 AM wrote: > > > On 26/04/23, 5:51 PM

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-02 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Mon, 2023-05-22 at 14:05 +0200, Richard Biener wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, May 19, 2023 at 7:58 AM wrote: > > On 26/04/23, 5:51 PM, "Richard Biener" > > wrote: > > > On We

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-22 Thread Richard Biener via Gcc-patches
On Fri, May 19, 2023 at 7:58 AM wrote: > > On 26/04/23, 5:51 PM, "Richard Biener" > wrote: > > On Wed, Apr 26, 2023 at 12:56 PM > > wrote: > > > > > > On Wed, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches >

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-19 Thread Jeff Law via Gcc-patches
On 5/19/23 08:02, Bernhard Reutner-Fischer via Gcc-patches wrote: On 19 May 2023 07:58:48 CEST, "SenthilKumar.Selvaraj--- via Gcc-patches" wrote: Just a nit: +static bool +avr_addr_space_zero_address_valid (addr_space_t as ATTRIBUTE_UNUSED) +{ + return flag_delete_null_pointer_checks ==

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On 19 May 2023 07:58:48 CEST, "SenthilKumar.Selvaraj--- via Gcc-patches" wrote: Just a nit: >+static bool >+avr_addr_space_zero_address_valid (addr_space_t as ATTRIBUTE_UNUSED) >+{ >+ return flag_delete_null_pointer_checks == 0; >+} Since we are c++ nowadays, you can omit the parameter name f

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-18 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On 26/04/23, 5:51 PM, "Richard Biener" mailto:richard.guent...@gmail.com>> wrote: > On Wed, Apr 26, 2023 at 12:56 PM > wrote: > > > > On Wed, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches > > mailto:gcc-patches@gcc.gnu.org>> wrote: > > > > > >

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread Richard Biener via Gcc-patches
On Wed, Apr 26, 2023 at 12:56 PM wrote: > > On Wed, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches > wrote: > > > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > > wrote: > > > > > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > > > Gcc-patches wrote: > > > > > >

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Wed, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches wrote: > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > wrote: > > > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > > Gcc-patches wrote: > > > > > > Hi, > > > > > > This patch fixes PR 105523 by setting param

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread Richard Biener via Gcc-patches
On Wed, Apr 26, 2023 at 11:42 AM Richard Biener wrote: > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > Gcc-patches wrote: > > > > Hi, > > > > This patch fixes PR 105523 by setting param_min_pagesize to 0 for the > > avr target. For this target, zero and offsets from zero are p

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread Richard Biener via Gcc-patches
On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via Gcc-patches wrote: > > Hi, > > This patch fixes PR 105523 by setting param_min_pagesize to 0 for the > avr target. For this target, zero and offsets from zero are perfectly > valid addresses, and the default value of param_min_pagesize

[PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, This patch fixes PR 105523 by setting param_min_pagesize to 0 for the avr target. For this target, zero and offsets from zero are perfectly valid addresses, and the default value of param_min_pagesize ends up triggering warnings on valid memory accesses. Ok for trunk and backporting to 13 and