Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-14 Thread Martin Sebor via Gcc-patches
On 5/13/21 10:53 PM, Bernd Edlinger wrote: On 5/14/21 12:35 AM, Martin Sebor wrote: On 5/13/21 11:36 AM, Martin Sebor wrote: On 5/13/21 11:20 AM, Bernd Edlinger wrote: On 5/13/21 3:55 AM, Martin Sebor via Gcc-patches wrote: A logic bug in the handling of PHI arguments in compute_objsize that

Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-13 Thread Bernd Edlinger
On 5/14/21 12:35 AM, Martin Sebor wrote: > On 5/13/21 11:36 AM, Martin Sebor wrote: >> On 5/13/21 11:20 AM, Bernd Edlinger wrote: >>> On 5/13/21 3:55 AM, Martin Sebor via Gcc-patches wrote: A logic bug in the handling of PHI arguments in compute_objsize that are all null pointers lets an

Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-13 Thread Martin Sebor via Gcc-patches
On 5/13/21 11:36 AM, Martin Sebor wrote: On 5/13/21 11:20 AM, Bernd Edlinger wrote: On 5/13/21 3:55 AM, Martin Sebor via Gcc-patches wrote: A logic bug in the handling of PHI arguments in compute_objsize that are all null pointers lets an incompletely populated struct be used in a way that trig

Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-13 Thread Jeff Law via Gcc-patches
On 5/12/2021 7:55 PM, Martin Sebor via Gcc-patches wrote: A logic bug in the handling of PHI arguments in compute_objsize that are all null pointers lets an incompletely populated struct be used in a way that triggers an assertion causing an ICE. The attached patch corrects that by having comp

Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-13 Thread Martin Sebor via Gcc-patches
On 5/13/21 11:20 AM, Bernd Edlinger wrote: On 5/13/21 3:55 AM, Martin Sebor via Gcc-patches wrote: A logic bug in the handling of PHI arguments in compute_objsize that are all null pointers lets an incompletely populated struct be used in a way that triggers an assertion causing an ICE. The att

Re: [PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-13 Thread Bernd Edlinger
On 5/13/21 3:55 AM, Martin Sebor via Gcc-patches wrote: > A logic bug in the handling of PHI arguments in compute_objsize > that are all null pointers lets an incompletely populated struct > be used in a way that triggers an assertion causing an ICE. > > The attached patch corrects that by having

[PATCH] avoid using an incompletely populated struct (PR 100574)

2021-05-12 Thread Martin Sebor via Gcc-patches
A logic bug in the handling of PHI arguments in compute_objsize that are all null pointers lets an incompletely populated struct be used in a way that triggers an assertion causing an ICE. The attached patch corrects that by having compute_objsize fail when the struct isn't fully populated (when