Re: [PATCH] avoid modifying type in place (PR 97206)

2020-09-30 Thread Richard Biener via Gcc-patches
On Wed, Sep 30, 2020 at 9:20 PM Martin Sebor via Gcc-patches wrote: > > On 9/30/20 3:57 AM, Jakub Jelinek wrote: > > On Tue, Sep 29, 2020 at 03:40:40PM -0600, Martin Sebor via Gcc-patches > > wrote: > >> I will commit this patch later this week unless I hear concerns > >> or suggestions for chang

Re: [PATCH] avoid modifying type in place (PR 97206)

2020-09-30 Thread Martin Sebor via Gcc-patches
On 9/30/20 3:57 AM, Jakub Jelinek wrote: On Tue, Sep 29, 2020 at 03:40:40PM -0600, Martin Sebor via Gcc-patches wrote: I will commit this patch later this week unless I hear concerns or suggestions for changes. That is not how the patch review process works. The review process hasn't been wo

Re: [PATCH] avoid modifying type in place (PR 97206)

2020-09-30 Thread Jakub Jelinek via Gcc-patches
On Tue, Sep 29, 2020 at 03:40:40PM -0600, Martin Sebor via Gcc-patches wrote: > I will commit this patch later this week unless I hear concerns > or suggestions for changes. That is not how the patch review process works. > + arat = tree_cons (get_identifier ("array"), flag, NULL_TREE); Be

[PATCH] avoid modifying type in place (PR 97206)

2020-09-29 Thread Martin Sebor via Gcc-patches
To render the bounds as well as the static specifier in array and VLA function parameters the new -Warray-parameter and -Wvla-parameter warning builds a "synthetic" array type that corresponds to the form of the parameter, sets its qualifiers to match those of the pointer, and passes it to the pr