Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-27 Thread Martin Sebor via Gcc-patches
On 3/26/20 6:52 PM, Jason Merrill wrote: On 3/26/20 4:57 PM, Martin Sebor wrote: On 3/25/20 3:56 PM, Jason Merrill wrote: On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully r

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-26 Thread Jason Merrill via Gcc-patches
On 3/26/20 4:57 PM, Martin Sebor wrote: On 3/25/20 3:56 PM, Jason Merrill wrote: On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ fron

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-26 Thread Martin Sebor via Gcc-patches
I have removed both calls to remove_attribute because with the changes to calls.c they are no longer needed. The revised patch is attached. I will plan to commit it tomorrow unless there's something else. In hindsight, I think changing the attribute from the human-readable form to the internal,

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-26 Thread Martin Sebor via Gcc-patches
On 3/25/20 3:56 PM, Jason Merrill wrote: On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ front-end).  The attached patch removes the r

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-25 Thread Jason Merrill via Gcc-patches
On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ front-end).  The attached patch removes the remaining modification that causes the ICE.

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-25 Thread Martin Sebor via Gcc-patches
Thanks for the suggestion to use type_cache_hasher::equal. I'll revisit the idea of adding an assertion to decl_attribute in stage 1 and will look into using it there. Until then, unless you or anyone else has any concerns with the original patch I will plan to commit tomorrow: https://gcc.gnu

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-18 Thread Jason Merrill via Gcc-patches
On 3/18/20 6:04 PM, Martin Sebor wrote: On 3/16/20 3:10 PM, Jason Merrill wrote: On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ fron

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-18 Thread Martin Sebor via Gcc-patches
On 3/16/20 3:10 PM, Jason Merrill wrote: On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ front-end).  The attached patch removes the r

Re: [PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-16 Thread Jason Merrill via Gcc-patches
On 3/16/20 4:41 PM, Martin Sebor wrote: The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ front-end).  The attached patch removes the remaining modification that causes the ICE.

[PATCH] avoid modifying type in attribute access handler [PR94098]

2020-03-16 Thread Martin Sebor via Gcc-patches
The recent fix to avoid modifying in place the type argument in handle_access_attribute (PR 92721) was incomplete and didn't fully resolve the problem (an ICE in the C++ front-end). The attached patch removes the remaining modification that causes the ICE. In addition, the change adjusts checkin