Re: [PATCH] attribs: Fix and refactor diag_attr_exclusions

2024-05-28 Thread Richard Sandiford
Andrew Carlotti writes: > The existing implementation of this function was convoluted, and had > multiple control flow errors that became apparent to me while reading > the code: > > 1. The initial early return only checked the properties of the first > exclusion in the list, when these properties

[PATCH] attribs: Fix and refactor diag_attr_exclusions

2024-05-16 Thread Andrew Carlotti
The existing implementation of this function was convoluted, and had multiple control flow errors that became apparent to me while reading the code: 1. The initial early return only checked the properties of the first exclusion in the list, when these properties could be different for subsequent e