Re: [PATCH] asf: Enable pass at O2 or higher

2025-05-06 Thread Konstantinos Eleftheriou
Hi Andi, thanks for your response. The pass prevents store forwarding only in cases where smaller stores are followed by a large load. To the best of our knowledge, on most CPUs, the load will stall in that case. Have you taken that into account? Thanks, Konstantinos On Wed, Apr 23, 2025 at 6:55

Re: [PATCH] asf: Enable pass at O2 or higher

2025-04-22 Thread Andi Kleen
On Wed, Jan 29, 2025 at 10:33:14AM +0100, Christoph Müllner wrote: > The avoid-store-forwarding pass is disabled by default and therefore > in the risk of bit-rotting. This patch addresses this by enabling > the pass at O2 or higher. > > The assembly patterns in `bitfield-bitint-abi-align16.c` an

Re: [PATCH] asf: Enable pass at O2 or higher

2025-04-22 Thread Konstantinos Eleftheriou
We have sent a new version for this, with updated testcases (https://gcc.gnu.org/pipermail/gcc-patches/2025-April/681606.html). Thanks, Konstantinos On Wed, Jan 29, 2025 at 8:32 PM Richard Sandiford wrote: > > Christoph Müllner writes: > > The avoid-store-forwarding pass is disabled by default

Re: [PATCH] asf: Enable pass at O2 or higher

2025-01-29 Thread Richard Sandiford
Christoph Müllner writes: > The avoid-store-forwarding pass is disabled by default and therefore > in the risk of bit-rotting. This patch addresses this by enabling > the pass at O2 or higher. > > The assembly patterns in `bitfield-bitint-abi-align16.c` and > `bitfield-bitint-abi-align8.c` have b

Re: [PATCH] asf: Enable pass at O2 or higher

2025-01-29 Thread Philipp Tomsich
+JiangNing Liu On Wed, 29 Jan 2025 at 10:38, Richard Biener wrote: > > On Wed, 29 Jan 2025, Christoph Müllner wrote: > > > The avoid-store-forwarding pass is disabled by default and therefore > > in the risk of bit-rotting. This patch addresses this by enabling > > the pass at O2 or higher. > >

Re: [PATCH] asf: Enable pass at O2 or higher

2025-01-29 Thread Richard Biener
On Wed, 29 Jan 2025, Christoph Müllner wrote: > The avoid-store-forwarding pass is disabled by default and therefore > in the risk of bit-rotting. This patch addresses this by enabling > the pass at O2 or higher. > > The assembly patterns in `bitfield-bitint-abi-align16.c` and > `bitfield-bitint

[PATCH] asf: Enable pass at O2 or higher

2025-01-29 Thread Christoph Müllner
The avoid-store-forwarding pass is disabled by default and therefore in the risk of bit-rotting. This patch addresses this by enabling the pass at O2 or higher. The assembly patterns in `bitfield-bitint-abi-align16.c` and `bitfield-bitint-abi-align8.c` have been updated to account for the ASF tra