Re: [PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-27 Thread Jakub Jelinek
On Mon, Jan 27, 2025 at 02:02:14PM +0100, Ilya Leoshkevich wrote: > Thank you for the review! > I have fixed the style and committed this. > > Would it be okay to backport this to gcc-13 and gcc-14? > Bootstrap and regtest pass on x86_64-redhat-linux. Ok. Jakub

Re: [PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-27 Thread Ilya Leoshkevich
On Fri, 2025-01-24 at 17:25 +0100, Jakub Jelinek wrote: > On Thu, Jan 09, 2025 at 01:15:30AM +0100, Ilya Leoshkevich wrote: > > Bootstrapped and regtested on x86_64-redhat-linux.  Ok for master? > > > > > > > > The FakeStack flag is not zeroed out when can_store_by_pieces() > > returns false.  O

Re: [PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-24 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 01:15:30AM +0100, Ilya Leoshkevich wrote: > Bootstrapped and regtested on x86_64-redhat-linux. Ok for master? > > > > The FakeStack flag is not zeroed out when can_store_by_pieces() > returns false. Over time, this causes FakeStack::Allocate() to perform > the maximum n

PING: [PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-23 Thread Ilya Leoshkevich
On Thu, 2025-01-09 at 01:15 +0100, Ilya Leoshkevich wrote: > Bootstrapped and regtested on x86_64-redhat-linux.  Ok for master? > > > > The FakeStack flag is not zeroed out when can_store_by_pieces() > returns false.  Over time, this causes FakeStack::Allocate() to > perform > the maximum number

[PATCH] asan: Fix missing FakeStack flag cleanup

2025-01-08 Thread Ilya Leoshkevich
Bootstrapped and regtested on x86_64-redhat-linux. Ok for master? The FakeStack flag is not zeroed out when can_store_by_pieces() returns false. Over time, this causes FakeStack::Allocate() to perform the maximum number of loop iterations, significantly slowing down the instrumented program.