RE: [PATCH] arm: Fix up arm_override_options_after_change_1

2020-09-10 Thread Kyrylo Tkachov
> -Original Message- > From: Jakub Jelinek > Sent: 10 September 2020 16:02 > To: Kyrylo Tkachov > Cc: Richard Earnshaw ; gcc- > patc...@gcc.gnu.org > Subject: Re: [PATCH] arm: Fix up arm_override_options_after_change_1 > > On Thu, Sep 10, 2020 at 02:11

Re: [PATCH] arm: Fix up arm_override_options_after_change_1

2020-09-10 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 10, 2020 at 02:11:25PM +, Kyrylo Tkachov wrote: > > > incorrect, rather than testing > > > !opts->x_str_align_functions > > > it should be really testing > > > !opts_set->x_str_align_functions > > > and get &global_options_set or similar passed to it as additional opts_set > > > arg

Re: [PATCH] arm: Fix up arm_override_options_after_change_1

2020-09-10 Thread Jeff Law via Gcc-patches
On Thu, 2020-09-10 at 14:11 +, Kyrylo Tkachov wrote: > Hi Jakub, > > > -Original Message- > > From: Jakub Jelinek > > Sent: 10 September 2020 09:51 > > To: Richard Earnshaw ; Kyrylo Tkachov > > ; gcc-patches@gcc.gnu.

RE: [PATCH] arm: Fix up arm_override_options_after_change_1

2020-09-10 Thread Kyrylo Tkachov
Hi Jakub, > -Original Message- > From: Jakub Jelinek > Sent: 10 September 2020 09:51 > To: Richard Earnshaw ; Kyrylo Tkachov > ; gcc-patches@gcc.gnu.org > Subject: [PATCH] arm: Fix up arm_override_options_after_change_1 > > On Tue, Sep 08, 2020 at 10:45:12AM +020

[PATCH] arm: Fix up arm_override_options_after_change_1

2020-09-10 Thread Jakub Jelinek via Gcc-patches
On Tue, Sep 08, 2020 at 10:45:12AM +0200, Jakub Jelinek via Gcc-patches wrote: > Looking further at arm_override_options_after_change_1, it also seems to be > incorrect, rather than testing > !opts->x_str_align_functions > it should be really testing > !opts_set->x_str_align_functions > and get &gl