GCN: Set 'UI_TARGET' for 'TARGET_EXCEPT_UNWIND_INFO' [PR94282, PR113331] (was: [gcn] Set 'UI_NONE' for 'TARGET_EXCEPT_UNWIND_INFO' [PR94282] (was: [PATCH] amdgcn: Add stub personality function))

Hi! On 2020-04-29T10:35:54+0200, I wrote: > On 2020-04-23T13:05:33+0200, I wrote: >> I suggest we [...] apply what I'd proposed a month ago in >> "[amdgcn] ld: error: undefined symbol: >> __gxx_personality_v0", and now yesterday (coincidentally) posted. > > Now pushed

[gcn] Set 'UI_NONE' for 'TARGET_EXCEPT_UNWIND_INFO' [PR94282] (was: [PATCH] amdgcn: Add stub personality function)

Hi! On 2020-04-23T13:05:33+0200, I wrote: > On 2020-04-23T09:15:29+0100, Andrew Stubbs wrote: >> On 22/04/2020 22:10, Kwok Cheung Yeung wrote: >>> [...] allows the following tests in the libgomp >>> testsuite that were previously failing with a linker error to compile >>> and run, provided that t

Re: [PATCH] amdgcn: Add stub personality function

On 23/04/2020 12:21, Kwok Cheung Yeung wrote: I agree that not generating the problematic code in the first place is the better approach. Does that mean we can now remove libgcc/config/gcn/unwind-gcn.c completely? That was added for the benefit of libgfortran, not C++. It's used by the backtr

Re: [PATCH] amdgcn: Add stub personality function

On 23/04/2020 12:05 pm, Thomas Schwinge wrote: So we should simply disable it properly (see below)... ... instead of adding such stub functions. I suggest we instead apply what I'd proposed a month ago in "[amdgcn] ld: error: undefined symbol: __gxx_personality_v0

Re: [PATCH] amdgcn: Add stub personality function

Hi! On 2020-04-23T09:15:29+0100, Andrew Stubbs wrote: > On 22/04/2020 22:10, Kwok Cheung Yeung wrote: >> This patch adds a stub implementation of __gxx_personality_v0, which is >> used in C++ exception handling. AMD GCN currently does not actually >> support exception handling So we should simpl

Re: [PATCH] amdgcn: Add stub personality function

On 22/04/2020 22:10, Kwok Cheung Yeung wrote: Hello This patch adds a stub implementation of __gxx_personality_v0, which is used in C++ exception handling. AMD GCN currently does not actually support exception handling (the unwind functions are all stubs too), so adding an extra stub function

[PATCH] amdgcn: Add stub personality function

Hello This patch adds a stub implementation of __gxx_personality_v0, which is used in C++ exception handling. AMD GCN currently does not actually support exception handling (the unwind functions are all stubs too), so adding an extra stub function does not regress the current level of function