Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Tom de Vries
On 9/28/20 4:17 PM, Andrew Stubbs wrote: > On 28/09/2020 15:02, Tom de Vries wrote: >>> This patch simply skips barriers when they would "wait" for only one >>> thread (the current thread). This means that teams nested inside other >>> teams now run independently, instead of strictly in lock-step,

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Andrew Stubbs
On 28/09/2020 15:02, Tom de Vries wrote: This patch simply skips barriers when they would "wait" for only one thread (the current thread). This means that teams nested inside other teams now run independently, instead of strictly in lock-step, and is only valid as long as inner teams are limited

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Tom de Vries
On 9/18/20 1:25 PM, Andrew Stubbs wrote: > This patch fixes a problem in which nested OpenMP parallel regions cause > errors if the number of inner teams is not balanced (i.e. the number of > loop iterations is not divisible by the number of physical threads). A > testcase is included. > > On NVPT

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-19 Thread Andrew Stubbs
On 18/09/2020 12:25, Andrew Stubbs wrote: This patch fixes a problem in which nested OpenMP parallel regions cause errors if the number of inner teams is not balanced (i.e. the number of loop iterations is not divisible by the number of physical threads). A testcase is included. This updated

[PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-18 Thread Andrew Stubbs
This patch fixes a problem in which nested OpenMP parallel regions cause errors if the number of inner teams is not balanced (i.e. the number of loop iterations is not divisible by the number of physical threads). A testcase is included. On NVPTX the symptom was a fatal error: libgomp: cuCtxS