Re: [PATCH] add -fprolog-pad=N option to c-family

2016-05-08 Thread AKASHI Takahiro
Hi, Let me make some comments from the kernel side. On Thu, Apr 28, 2016 at 11:58:25AM +0100, Szabolcs Nagy wrote: > On 28/04/16 09:47, Maxim Kuvyrkov wrote: > >> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: > >> > >> with -mfentry, by default the user only has to > >> implement the fentry

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Jeff Law
On 04/28/2016 05:18 AM, Torsten Duwe wrote: On Thu, Apr 28, 2016 at 11:39:48AM +0300, Maxim Kuvyrkov wrote: On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: Your current patch is great for experiments for the kernel engineers to check if suggested approaches to code patching will work. Stil

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Torsten Duwe
On Thu, Apr 28, 2016 at 11:58:25AM +0100, Szabolcs Nagy wrote: > On 28/04/16 09:47, Maxim Kuvyrkov wrote: > >> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: > >> > >> with -mfentry, by default the user only has to > >> implement the fentry call (linux wants nops there, but > >> e.g. glibc coul

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Torsten Duwe
On Thu, Apr 28, 2016 at 11:39:48AM +0300, Maxim Kuvyrkov wrote: > > On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: > > Your current patch is great for experiments for the kernel engineers to check > if suggested approaches to code patching will work. Still, I prefer to > implement LTO-friend

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Szabolcs Nagy
On 28/04/16 09:47, Maxim Kuvyrkov wrote: >> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: >> >> with -mfentry, by default the user only has to >> implement the fentry call (linux wants nops there, but >> e.g. glibc could use -pg -mfentry for profiling on >> aarch64 and the target specific deta

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Maxim Kuvyrkov
> On Apr 27, 2016, at 7:26 PM, Szabolcs Nagy wrote: > > On 27/04/16 16:22, Torsten Duwe wrote: >> Hi Maxim, >> >> thanks for starting the work on this; I have added the missing >> command line option. It builds now and the resulting compiler generates >> a linux kernel with the desired propertie

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-28 Thread Maxim Kuvyrkov
> On Apr 27, 2016, at 6:22 PM, Torsten Duwe wrote: > > Hi Maxim, > > thanks for starting the work on this; I have added the missing > command line option. It builds now and the resulting compiler generates > a linux kernel with the desired properties, so work can continue there. Thanks for work

Re: [PATCH] add -fprolog-pad=N option to c-family

2016-04-27 Thread Szabolcs Nagy
On 27/04/16 16:22, Torsten Duwe wrote: > Hi Maxim, > > thanks for starting the work on this; I have added the missing > command line option. It builds now and the resulting compiler generates > a linux kernel with the desired properties, so work can continue there. > > Torsten i guess the

[PATCH] add -fprolog-pad=N option to c-family

2016-04-27 Thread Torsten Duwe
Hi Maxim, thanks for starting the work on this; I have added the missing command line option. It builds now and the resulting compiler generates a linux kernel with the desired properties, so work can continue there. Torsten diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c