Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-07 Thread Jan Hubicka
> On 08/04/2017 11:15 AM, Jan Hubicka wrote: > >>>OK for trunk if bootstrap and reg-test on x86_64 succeeds? > >>Yea, but I'd like to see ongoing work towards full checking. > > > >I have full checking in my tree for some time. At x86-64 bootstrap there > >is one remaining offender in simd_clone_a

Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-06 Thread Tom de Vries
On 08/04/2017 11:15 AM, Jan Hubicka wrote: III. I've written this patch to check for the missing probability more consistently. I'm not certain if we can require that the probability should always be set, so I'm just requiring that if it is set on one outgoing edge, it needs to be set on all ou

Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-04 Thread Tom de Vries
On 08/04/2017 11:15 AM, Jan Hubicka wrote: OK for trunk if bootstrap and reg-test on x86_64 succeeds? Yea, but I'd like to see ongoing work towards full checking. I have full checking in my tree for some time. At x86-64 bootstrap there is one remaining offender in simd_clone_adjust which was

Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-04 Thread Jan Hubicka
> > > > III. > > > > I've written this patch to check for the missing probability more > > consistently. I'm not certain if we can require that the probability > > should always be set, so I'm just requiring that if it is set on one > > outgoing edge, it needs to be set on all outgoing edges. > >

Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-03 Thread Jeff Law
On 08/02/2017 10:07 AM, Tom de Vries wrote: > Hi, > > I. > > for target nvptx we recently ran into PR81442, an ICE in verify_flow_info: > ... > error: verify_flow_info: REG_BR_PROB is set but cfg probability is not > ... > > We start out with a jump instruction: > ... > (jump_insn 18 17 31 2 (se

[PATCH] Verify edge probability consistency in verify_flow_info

2017-08-02 Thread Tom de Vries
Hi, I. for target nvptx we recently ran into PR81442, an ICE in verify_flow_info: ... error: verify_flow_info: REG_BR_PROB is set but cfg probability is not ... We start out with a jump instruction: ... (jump_insn 18 17 31 2 (set (pc) (if_then_else (ne (reg:BI 83) (const