Re: [PATCH] V4, patch #1: Rework prefixed/pc-relative lookup

2019-09-23 Thread Michael Meissner
On Fri, Sep 20, 2019 at 08:29:04PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Wed, Sep 18, 2019 at 07:49:18PM -0400, Michael Meissner wrote: > > This patch reworks the prefixed and pc-relative memory matching functions. > > This mostly looks fine, thanks! A few smaller things: > > > >

Re: [PATCH] V4, patch #1: Rework prefixed/pc-relative lookup

2019-09-20 Thread Segher Boessenkool
Hi Mike, On Wed, Sep 18, 2019 at 07:49:18PM -0400, Michael Meissner wrote: > This patch reworks the prefixed and pc-relative memory matching functions. This mostly looks fine, thanks! A few smaller things: > (pcrel_external_address): Replace with new implementation using > address_

[PATCH] V4, patch #1: Rework prefixed/pc-relative lookup

2019-09-18 Thread Michael Meissner
This patch reworks the prefixed and pc-relative memory matching functions. As I said in the intro message, I do not re-use the address mask bits in reg_addr, but instead, I have a separate function that takes an address and decodes it into the various different flavors (single register address, D-