Re: [PATCH] Use 1UL constant in order to not overflow (PR c++/89383).

2019-02-18 Thread Martin Liška
On 2/18/19 9:54 AM, Jakub Jelinek wrote: > On Mon, Feb 18, 2019 at 09:46:33AM +0100, Martin Liška wrote: >> Hi. >> >> The patch handles an undefined behavior caused by 1U << 32 shift >> for an integer type. > > That will still ICE on 32-bit hosts, won't it? > So, either you need ((uint64_t) 1) <<

Re: [PATCH] Use 1UL constant in order to not overflow (PR c++/89383).

2019-02-18 Thread Jakub Jelinek
On Mon, Feb 18, 2019 at 09:46:33AM +0100, Martin Liška wrote: > Hi. > > The patch handles an undefined behavior caused by 1U << 32 shift > for an integer type. That will still ICE on 32-bit hosts, won't it? So, either you need ((uint64_t) 1) << ..., or column_bits && ... >= ... > 2019-02-18 Mar

[PATCH] Use 1UL constant in order to not overflow (PR c++/89383).

2019-02-18 Thread Martin Liška
Hi. The patch handles an undefined behavior caused by 1U << 32 shift for an integer type. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin libcpp/ChangeLog: 2019-02-18 Martin Liska PR c++/89383 * line-map.c (linema