Re: [PATCH] Update SSA_NAME manager to use two lists

2015-10-23 Thread Jeff Law
On 10/01/2015 04:00 AM, Richard Biener wrote: Apart from what Jakub said - this keeps the list non-recycled for example after DCE if that doesnt call cleanup_cfg. Likewise after passes that call cleanup_cfg manually. It also doesn't get called after IPA transform passes (which would require ca

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-10-09 Thread Jeff Law
the data. Fixed thusly. Bootstrapped and regression tested on x86_64-linux-gnu. Installed on the trunk. jeff commit 158044e96e95e4637a7c9519f864ec07d6a596de Author: Jeff Law Date: Fri Oct 9 15:14:16 2015 -0600 Re: [PATCH] Update SSA_NAME manager to use two lists * tree-ss

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-10-01 Thread Jeff Law
On 10/01/2015 04:00 AM, Richard Biener wrote: Apart from what Jakub said - this keeps the list non-recycled for example after DCE if that doesnt call cleanup_cfg. Likewise after passes that call cleanup_cfg manually. It also doesn't get called after IPA transform passes (which would require c

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-10-01 Thread Richard Biener
On Wed, Sep 30, 2015 at 7:44 PM, Jeff Law wrote: > > The SSA_NAME manager currently has a single free list. As names are > released, they're put on the free list and recycled immediately. > > This has led to several problems through the years -- in particular removal > of an edge may result in re

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jeff Law
On 09/30/2015 12:46 PM, Jakub Jelinek wrote: On Wed, Sep 30, 2015 at 11:44:38AM -0600, Jeff Law wrote: +/* Move all SSA_NAMEs from FREE_SSA_NAMES_QUEUE to FREE_SSA_NAMES. + + We do not, but should have a mode to verify the state of the SSA_NAMEs + lists. In particular at this point every na

Re: [PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jakub Jelinek
On Wed, Sep 30, 2015 at 11:44:38AM -0600, Jeff Law wrote: > +/* Move all SSA_NAMEs from FREE_SSA_NAMES_QUEUE to FREE_SSA_NAMES. > + > + We do not, but should have a mode to verify the state of the SSA_NAMEs > + lists. In particular at this point every name must be in the IL, > + on the free

[PATCH] Update SSA_NAME manager to use two lists

2015-09-30 Thread Jeff Law
The SSA_NAME manager currently has a single free list. As names are released, they're put on the free list and recycled immediately. This has led to several problems through the years -- in particular removal of an edge may result in removal of a PHI when the target of the edge is unreachab