Re: [PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread Jakub Jelinek
On Thu, Jul 14, 2016 at 02:29:10PM -0400, David Malcolm wrote: > > Tested on x86_64-linux and i686-linux, ok for trunk? > > Thanks. I think I can approve this with my "libcpp/diagnostic messages > " maintainer hat on. > > Did you test the case with a build for one of the affected targets to > ve

Re: [PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread David Malcolm
On Thu, 2016-07-14 at 16:55 +0200, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, this testcase behaves differently on > powerpc*/spu/s390* targets, because in non-iso modes they predefine > conditional macros like bool and that affects the behavior of the > suggestions. > > We should cer

[PATCH] Tweak diagnostic-token.ranges.c testcase (PR testsuite/71865)

2016-07-14 Thread Jakub Jelinek
Hi! As mentioned in the PR, this testcase behaves differently on powerpc*/spu/s390* targets, because in non-iso modes they predefine conditional macros like bool and that affects the behavior of the suggestions. We should certainly discuss what to do with the conditional macros, but in the mean t