Re: [PATCH] Turn on LRA on all targets

On Fri, 16 Feb 2024, Maciej W. Rozycki wrote: > On Fri, 16 Feb 2024, Jakub Jelinek wrote: > > > > There is no function prologue to optimise in the VAX case, because all > > > the frame setup has already been made by the CALLS instruction itself in > > > the caller. The first machine instructi

Re: [PATCH] Turn on LRA on all targets

On Fri, 16 Feb 2024, Jakub Jelinek wrote: > > There is no function prologue to optimise in the VAX case, because all > > the frame setup has already been made by the CALLS instruction itself in > > the caller. The first machine instruction of the callee is technically > > already past the "pr

Re: [PATCH] Turn on LRA on all targets

> On Feb 16, 2024, at 6:34 AM, Maciej W. Rozycki wrote: > > On Thu, 15 Feb 2024, Paul Koning wrote: > >>> On May 15, 2023, at 5:09 PM, Maciej W. Rozycki wrote: >>> >>> ... >>> >>> I may choose to implement a non-DWARF unwinder instead, as the VAX stack >>> frame is always fully described

Re: [PATCH] Turn on LRA on all targets

On Fri, Feb 16, 2024 at 02:23:54PM +, Maciej W. Rozycki wrote: > On Fri, 16 Feb 2024, Segher Boessenkool wrote: > > > > Conversely no heuristics is required to unwind VAX frames, because they > > > are fixed in layout by hardware, fully self-described, and with the > > > hardware frame poin

Re: [PATCH] Turn on LRA on all targets

On Fri, 16 Feb 2024, Segher Boessenkool wrote: > > Conversely no heuristics is required to unwind VAX frames, because they > > are fixed in layout by hardware, fully self-described, and with the > > hardware frame pointer always available. > > The downside of the VAX situation of course is tha

Re: [PATCH] Turn on LRA on all targets

On Fri, Feb 16, 2024 at 11:34:55AM +, Maciej W. Rozycki wrote: > Not really, in particular because EH unwinding has to be reliable and > heuristics inherently is not. Yup. Which is why I did 0359465c703a for rs6000 six years ago (how time flies!) The commit message for that includes T

Re: [PATCH] Turn on LRA on all targets

On Thu, 15 Feb 2024, Paul Koning wrote: > > On May 15, 2023, at 5:09 PM, Maciej W. Rozycki wrote: > > > > ... > > > > I may choose to implement a non-DWARF unwinder instead, as the VAX stack > > frame is always fully described by the hardware and there is never ever a > > need for debug infor

Re: [PATCH] Turn on LRA on all targets

On Thu, Feb 15, 2024 at 08:41:42PM -0500, Paul Koning wrote: > > On Feb 15, 2024, at 5:56 PM, Segher Boessenkool > > wrote: > > > > On Thu, Feb 15, 2024 at 07:34:32PM +, Sam James wrote: > >> I have now started doing this in PR113932. > > > > Thank you! > > > > Segher > > Presumably this

Re: [PATCH] Turn on LRA on all targets

> On Feb 15, 2024, at 5:56 PM, Segher Boessenkool > wrote: > > On Thu, Feb 15, 2024 at 07:34:32PM +, Sam James wrote: >> I have now started doing this in PR113932. > > Thank you! > > Segher Presumably this isn't for version 14 since it's in a late stage, right? I have my bits about r

Re: [PATCH] Turn on LRA on all targets

On Thu, Feb 15, 2024 at 07:34:32PM +, Sam James wrote: > I have now started doing this in PR113932. Thank you! Segher

Re: [PATCH] Turn on LRA on all targets

> On May 15, 2023, at 5:09 PM, Maciej W. Rozycki wrote: > > ... > > I may choose to implement a non-DWARF unwinder instead, as the VAX stack > frame is always fully described by the hardware and there is never ever a > need for debug information to be able to decode any VAX stack frame (the

Re: [PATCH] Turn on LRA on all targets

Sam James writes: > [[PGP Signed Part:Undecided]] > > "Maciej W. Rozycki" writes: > >> On Sun, 23 Apr 2023, Segher Boessenkool wrote: >> >>> > There are extra ICEs in regression testing and code quality is poor; cf. >>> > .

Flip the nvptx port to LRA (was: [PATCH] Turn on LRA on all targets)

Hi! On 2023-04-29T09:06:54-0600, Jeff Law via Gcc-patches wrote: > On 4/29/23 07:37, Roger Sayle wrote: >> >> Segher Boessenkool wrote: >>> I send this patch now so that people can start testing. >>> >>> --- a/gcc/config/nvptx/nvptx.cc >>> +++ b/gcc/config/nvptx/nvptx.cc >>> @@ -7601,9 +7601,6 @

Re: [PATCH] Turn on LRA on all targets

"Maciej W. Rozycki" writes: > On Sun, 23 Apr 2023, Segher Boessenkool wrote: > >> > There are extra ICEs in regression testing and code quality is poor; cf. >> > . >> >> Do you have something you can show for this? Maybe i

Re: [PATCH] Turn on LRA on all targets

On Sun, 23 Apr 2023, Segher Boessenkool wrote: > > There are extra ICEs in regression testing and code quality is poor; cf. > > . > > Do you have something you can show for this? Maybe in a PR? I have filed no PRs as I did

Re: [PATCH] Turn on LRA on all targets

On 4/23/23 10:47, Segher Boessenkool wrote: This minimal patch enables LRA for all targets. It does not clean up the target code, nor does it do anything to generic code: it just deletes all target definitions of TARGET_LRA_P. There are three kinds of changes: 1) Targets that already always

Re: [PATCH] Turn on LRA on all targets

On 4/29/23 07:37, Roger Sayle wrote: Segher Boessenkool wrote: I send this patch now so that people can start testing. diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc index 89349dae9e62..e32f17377525 100644 --- a/gcc/config/nvptx/nvptx.cc +++ b/gcc/config/nvptx/nvptx.cc @

Re: [PATCH] Turn on LRA on all targets

Hi! On Mon, Apr 24, 2023 at 11:46:50AM +0200, Uros Bizjak wrote: > On Mon, Apr 24, 2023 at 11:19 AM Segher Boessenkool > wrote: > > We still need someone to test this on alpha now, years later, and give > > a final okay, but hearing this is encouraging :-) > > Please note that bootstrap worked o

Re: [PATCH] Turn on LRA on all targets

Segher Boessenkool wrote: > I send this patch now so that people can start testing. > > diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc > index 89349dae9e62..e32f17377525 100644 > --- a/gcc/config/nvptx/nvptx.cc > +++ b/gcc/config/nvptx/nvptx.cc > @@ -7601,9 +7601,6 @@ nvptx_as

Re: [PATCH] Turn on LRA on all targets

On Mon, Apr 24, 2023 at 11:19 AM Segher Boessenkool wrote: > > On Sun, Apr 23, 2023 at 11:06:41PM +0200, Uros Bizjak wrote: > > > I send this patch now so that people can start testing. I don't plan to > > > commit this for another week at least, for a week after GCC 13 release I > > > guess? Ho

Re: [PATCH] Turn on LRA on all targets

On Mon, Apr 24, 2023 at 10:19:23AM +0200, Richard Biener wrote: > On Sun, Apr 23, 2023 at 6:48 PM Segher Boessenkool > wrote: > > > > This minimal patch enables LRA for all targets. It does not clean up > > the target code, nor does it do anything to generic code: it just > > deletes all target d

Re: [PATCH] Turn on LRA on all targets

On Sun, Apr 23, 2023 at 11:06:41PM +0200, Uros Bizjak wrote: > > I send this patch now so that people can start testing. I don't plan to > > commit this for another week at least, for a week after GCC 13 release I > > guess? How does that plan sound to people? > > An old patch to enable Alpha is

Re: [PATCH] Turn on LRA on all targets

Here is the result for m68k: libtool: compile: /daten/aranym/gcc/gcc-20230424/Build/./gcc/xgcc -shared-libgcc -B/daten/aranym/gcc/gcc-20230424/Build/./gcc -nostdinc++ -L/daten/aranym/gcc/gcc-20230424/Build/m68k-linux/libstdc++-v3/src -L/daten/aranym/gcc/gcc-20230424/Build/m68k-linux/libstdc++-

Re: [PATCH] Turn on LRA on all targets

On Sun, Apr 23, 2023 at 6:48 PM Segher Boessenkool wrote: > > This minimal patch enables LRA for all targets. It does not clean up > the target code, nor does it do anything to generic code: it just > deletes all target definitions of TARGET_LRA_P. > > There are three kinds of changes: > > 1) Tar

Re: [PATCH] Turn on LRA on all targets

On Sun, Apr 23, 2023 at 6:48 PM Segher Boessenkool wrote: > > This minimal patch enables LRA for all targets. It does not clean up > the target code, nor does it do anything to generic code: it just > deletes all target definitions of TARGET_LRA_P. > > There are three kinds of changes: > > 1) Tar

Re: [PATCH] Turn on LRA on all targets

On Sun, Apr 23, 2023 at 07:56:56PM +0100, Maciej W. Rozycki wrote: > On Sun, 23 Apr 2023, Segher Boessenkool wrote: > > 1) Targets that already always have LRA, but that redefine the hook > > anyway. These are gcn, pdp11, rx, sparc, vax, and xtensa. Nothing > > really changes for these targets wi

Re: [PATCH] Turn on LRA on all targets

(You didn't leave me in Cc: on the reply. Maybe you did a reply-to-only-one-person?) On Sun, Apr 23, 2023 at 11:01:05AM -0600, Jeff Law via Gcc-patches wrote: > On 4/23/23 10:47, Segher Boessenkool wrote: > >3) Targets that as of yet never used LRA. Many of those will be fine, > >but some others

Re: [PATCH] Turn on LRA on all targets

Hi! On Sun, Apr 23, 2023 at 02:36:05PM -0400, Paul Koning wrote: > > On Apr 23, 2023, at 12:47 PM, Segher Boessenkool > > wrote: > > 1) Targets that already always have LRA, but that redefine the hook > > anyway. These are gcn, pdp11, rx, sparc, vax, and xtensa. Nothing > > really changes for

Re: [PATCH] Turn on LRA on all targets

On Sun, 23 Apr 2023, Segher Boessenkool wrote: > 1) Targets that already always have LRA, but that redefine the hook > anyway. These are gcn, pdp11, rx, sparc, vax, and xtensa. Nothing > really changes for these targets with this patch (but later patches > will delete the superfluous hook implem

Re: [PATCH] Turn on LRA on all targets

> On Apr 23, 2023, at 12:47 PM, Segher Boessenkool > wrote: > > This minimal patch enables LRA for all targets. It does not clean up > the target code, nor does it do anything to generic code: it just > deletes all target definitions of TARGET_LRA_P. > > There are three kinds of changes: >

Re: [PATCH] Turn on LRA on all targets

On 4/23/23 10:47, Segher Boessenkool wrote: 3) Targets that as of yet never used LRA. Many of those will be fine, but some others will need a little tuning, and a few might need some actual improvements to LRA itself. These are cris, epiphany, fr30, frv, h8300, ia64, iq2000, lm32, m32c, m32r

[PATCH] Turn on LRA on all targets

This minimal patch enables LRA for all targets. It does not clean up the target code, nor does it do anything to generic code: it just deletes all target definitions of TARGET_LRA_P. There are three kinds of changes: 1) Targets that already always have LRA, but that redefine the hook anyway. Th