Re: [PATCH] Time profiler - phase 1

2013-11-25 Thread Christophe Lyon
On 11 November 2013 18:52, Martin Liška wrote: >>> +2013-10-28 Martin Liska >>> + >>> + * gcc.dg/time-profiler-1.c: New test. >>> + * gcc.dg/time-profiler-2.c: Ditto. >>> + > > Yes, I do have commit right. I will bootstrap the patch, test Inkscape > instrumentation and commit it. >

Re: [PATCH] Time profiler - phase 1

2013-11-12 Thread Rong Xu
Thanks. I'll have this change included in my libgcov.c re-re-factoring patch. -Rong On Tue, Nov 12, 2013 at 10:18 AM, Martin Liška wrote: > Hi Rong, > you are right, that's the only usage and so that you can declare it > static. > > Thank you, > Martin > > On Nov 12, 2013 7:10 PM, "Rong Xu" w

Re: [PATCH] Time profiler - phase 1

2013-11-12 Thread Rong Xu
A question about the newly added global variable function_counter. Does it have to be a global? Can I make it a file static, within macro L_gcov_time_profiler? I don't find a use other than in __gcov_time_profiler(). thanks, -Rong On Mon, Nov 11, 2013 at 9:52 AM, Martin Liška wrote: > On 11 N

Re: [PATCH] Time profiler - phase 1

2013-11-11 Thread Martin Liška
On 11 November 2013 15:57, Jan Hubicka wrote: >> +2013-10-29 Martin Liska >> + Jan Hubicka >> + >> + * cgraph.c (dump_cgraph_node): Profile dump added. >> + * cgraph.h (struct cgraph_node): New time profile variable added. >> + * cgraphc

Re: [PATCH] Time profiler - phase 1

2013-11-11 Thread Jan Hubicka
> +2013-10-29 Martin Liska > + Jan Hubicka > + > + * cgraph.c (dump_cgraph_node): Profile dump added. > + * cgraph.h (struct cgraph_node): New time profile variable added. > + * cgraphclones.c (cgraph_clone_node): Time profile is cloned.

Re: [PATCH] Time profiler - phase 1

2013-11-05 Thread Martin Liška
Hello, there's updated version of the first phase patch (including 2 new tests). Martin On 4 November 2013 11:46, Jan Hubicka wrote: >> diff --git a/gcc/ChangeLog b/gcc/ChangeLog >> index fca665b..3b62bcc 100644 >> --- a/gcc/ChangeLog >> +++ b/gcc/ChangeLog >> @@ -1,3 +1,31 @@ >> +2013-10-29

Re: [PATCH] Time profiler - phase 1

2013-11-04 Thread Jan Hubicka
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index fca665b..3b62bcc 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,31 @@ > +2013-10-29 Martin Liska > + Jan Hubicka > + > + * cgraph.c (dump_cgraph_node): Profile dump added. > +

Re: [PATCH] Time profiler - phase 1

2013-10-31 Thread Andi Kleen
Martin Liška writes: > Hello, >I've cooperating with Jan on a new profile-based function > reordering stuff. This first patch introduces a new GCOV counter that > instruments each function call and stores the time of first run of a > function. I'm curious, do you have any numbers how much th

[PATCH] Time profiler - phase 1

2013-10-29 Thread Martin Liška
Hello, I've cooperating with Jan on a new profile-based function reordering stuff. This first patch introduces a new GCOV counter that instruments each function call and stores the time of first run of a function. Bootstrapped/regtested on x86_64-linux and i686-linux. Thanks, Martin diff --git