Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 3:48 PM Andrew MacLeod wrote: > > > On 8/16/22 06:25, Aldy Hernandez wrote: > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > >> The remaining issue I have with the path_range_query is that > >> we re-use the same instance in the back threader but the > >> class

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 06:25, Aldy Hernandez wrote: On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: The remaining issue I have with the path_range_query is that we re-use the same instance in the back threader but the class doesn't provide any way to "restart", aka give m_path a lifetime. The "st

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 05:28, Richard Biener wrote: On Tue, 16 Aug 2022, Aldy Hernandez wrote: On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: On Tue, 16 Aug 2022, Aldy Hernandez wrote: On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wro

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022, 14:26 Richard Biener wrote: > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 16, 2022 at 1:38 PM Richard Biener > wrote: > > > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener > wrote: > > > > > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 16, 2022 at 1:38 PM Richard Biener wrote: > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > > > > > The remaining issue I have with the path_range_query is that > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 1:38 PM Richard Biener wrote: > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > > > The remaining issue I have with the path_range_query is that > > > we re-use the same instance in the back threader but the

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > The remaining issue I have with the path_range_query is that > > we re-use the same instance in the back threader but the > > class doesn't provide any way to "restart", aka give m_path > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > The remaining issue I have with the path_range_query is that > we re-use the same instance in the back threader but the > class doesn't provide any way to "restart", aka give m_path > a lifetime. The "start a new path" API seems to essent

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > On Thu, 11 Aug 2022, Aldy Hernandez wrote: > > > > > On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod > > > wrote: > > > > > > > > > > > > On 8/11/22 07:42, Richard Biener wrote: > > > > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: > > > > On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener > > > > wrote:

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: > > On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > > > > > @@ -599,6 +592,30 @@ path_range_query::compute_import

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > > > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, > > > const vec &path) > > > worklis

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > On Thu, 11 Aug 2022, Aldy Hernandez wrote: > > > On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod wrote: > > > > > > > > > On 8/11/22 07:42, Richard Biener wrote: > > > > This avoids going BBs outside of the path when adding def chains > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, > > const vec &path) > > worklist.safe_push (arg); > > } > > } > > + else if

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, const > vec &path) > worklist.safe_push (arg); > } > } > + else if (gassign *ass = dyn_cast (def_stmt)) > + { > +

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-15 Thread Richard Biener via Gcc-patches
On Thu, 11 Aug 2022, Aldy Hernandez wrote: > On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod wrote: > > > > > > On 8/11/22 07:42, Richard Biener wrote: > > > This avoids going BBs outside of the path when adding def chains > > > to the set of imports. It also syncs the code with > > > range_def_c

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-11 Thread Aldy Hernandez via Gcc-patches
On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod wrote: > > > On 8/11/22 07:42, Richard Biener wrote: > > This avoids going BBs outside of the path when adding def chains > > to the set of imports. It also syncs the code with > > range_def_chain::get_def_chain to not miss out on some imports > > th

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-11 Thread Andrew MacLeod via Gcc-patches
On 8/11/22 07:42, Richard Biener wrote: This avoids going BBs outside of the path when adding def chains to the set of imports. It also syncs the code with range_def_chain::get_def_chain to not miss out on some imports this function would identify. Bootstrap / regtest pending on x86_64-unknow

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-11 Thread Aldy Hernandez via Gcc-patches
OK On Thu, Aug 11, 2022, 13:42 Richard Biener wrote: > This avoids going BBs outside of the path when adding def chains > to the set of imports. It also syncs the code with > range_def_chain::get_def_chain to not miss out on some imports > this function would identify. > > Bootstrap / regtest p

[PATCH] Tame path_range_query::compute_imports

2022-08-11 Thread Richard Biener via Gcc-patches
This avoids going BBs outside of the path when adding def chains to the set of imports. It also syncs the code with range_def_chain::get_def_chain to not miss out on some imports this function would identify. Bootstrap / regtest pending on x86_64-unknown-linux-gnu. The question still stands on w