Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 19 April 2018 at 10:37, Martin Liška wrote: > On 04/18/2018 10:51 PM, Christophe Lyon wrote: >> Hi, >> >> >> On 17 April 2018 at 10:19, Jan Hubicka wrote: On 04/17/2018 08:58 AM, Jakub Jelinek wrote: > On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: >> + if

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 04/18/2018 10:51 PM, Christophe Lyon wrote: > Hi, > > > On 17 April 2018 at 10:19, Jan Hubicka wrote: >>> On 04/17/2018 08:58 AM, Jakub Jelinek wrote: On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: > + if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) > +

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

Hi, On 17 April 2018 at 10:19, Jan Hubicka wrote: >> On 04/17/2018 08:58 AM, Jakub Jelinek wrote: >> > On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: >> >> + if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) >> >> +{ >> >> + warn_odr (t1, t2, f1, f2

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 04/17/2018 10:33 AM, Jakub Jelinek wrote: > On Tue, Apr 17, 2018 at 10:29:35AM +0200, Martin Liška wrote: >> On 04/17/2018 10:28 AM, Martin Liška wrote: >>> I'm sending patch candidate. >> >> This one is the right one. > > Ok for stage1 with appropriate ChangeLog entries. > > Jakub > G

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On Tue, Apr 17, 2018 at 10:17:15AM +0200, Martin Liška wrote: > Sure. I see other format violations, should I fix that in follow up patch: > > gcc/c-family/c-warn.c: ? G_ ("floating point overflow in expression > %qE " > gcc/c-family/c-warn.c: : G_ ("floating point overflow in

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On Tue, Apr 17, 2018 at 10:29:35AM +0200, Martin Liška wrote: > On 04/17/2018 10:28 AM, Martin Liška wrote: > > I'm sending patch candidate. > > This one is the right one. Ok for stage1 with appropriate ChangeLog entries. Jakub

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 04/17/2018 10:28 AM, Martin Liška wrote: > I'm sending patch candidate. This one is the right one. Martin diff --git a/gcc/c-family/c-warn.c b/gcc/c-family/c-warn.c index d0d9c7894a8..2614eb58f14 100644 --- a/gcc/c-family/c-warn.c +++ b/gcc/c-family/c-warn.c @@ -98,10 +98,10 @@ overflow_warnin

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 04/17/2018 10:21 AM, Jakub Jelinek wrote: > On Tue, Apr 17, 2018 at 10:17:15AM +0200, Martin Liška wrote: >> Sure. I see other format violations, should I fix that in follow up patch: >> >> gcc/c-family/c-warn.c: ? G_ ("floating point overflow in >> expression %qE " >> gcc/c-family/c-

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

> On 04/17/2018 08:58 AM, Jakub Jelinek wrote: > > On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: > >> + if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) > >> +{ > >> + warn_odr (t1, t2, f1, f2, warn, warned, > >> +G_ ("one fie

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On 04/17/2018 08:58 AM, Jakub Jelinek wrote: > On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: >> +if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) >> + { >> +warn_odr (t1, t2, f1, f2, warn, warned, >> + G_ ("one field i

Re: [PATCH] Support bitfields in Wodr machinery (PR lto/85405).

On Tue, Apr 17, 2018 at 07:39:20AM +0200, Martin Liška wrote: > + if (DECL_BIT_FIELD (f1) != DECL_BIT_FIELD (f2)) > + { > + warn_odr (t1, t2, f1, f2, warn, warned, > + G_ ("one field is bitfield while other is not ")); I think all

[PATCH] Support bitfields in Wodr machinery (PR lto/85405).

Hi. This is Honza's ODR warning patch that I've just tested. He approved that. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Martin gcc/ChangeLog: 2018-04-16 Jan Hubicka PR lto/85405 * ipa-devirt.c (odr_types_equivalent_p): Handle bit fields. gcc/te