Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-13 Thread Eric Botcazou
> Then I think we can put all bits together now: > > 1. Let Sandra apply her Bit-fields patch "reimplement > -fstrict-volatile-bitfields v4, part 1/2" which was > posted here: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg02058.html > and approved here: http://gcc.gnu.org/ml/gcc-patches/2013-10/msg

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-10 Thread Richard Biener
On Tue, Dec 10, 2013 at 10:31 AM, Bernd Edlinger wrote: > Hi, > > > On Mon, 9 Dec 2013 14:18:23, Richard Biener wrote: >> >> On Mon, Dec 9, 2013 at 1:39 PM, Bernd Edlinger >> wrote: >>> On Fri, 6 Dec 2013 11:51:15, Richard Biener wrote: On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger >>

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-10 Thread Bernd Edlinger
Hi, On Mon, 9 Dec 2013 14:18:23, Richard Biener wrote: > > On Mon, Dec 9, 2013 at 1:39 PM, Bernd Edlinger > wrote: >> On Fri, 6 Dec 2013 11:51:15, Richard Biener wrote: >>> >>> On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger >>> wrote: Hi, On Thu, 5 Dec 2013 15:10:51, Richard Bie

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-09 Thread Richard Biener
On Mon, Dec 9, 2013 at 1:39 PM, Bernd Edlinger wrote: > On Fri, 6 Dec 2013 11:51:15, Richard Biener wrote: >> >> On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger >> wrote: >>> Hi, >>> >>> On Thu, 5 Dec 2013 15:10:51, Richard Biener wrote: On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger >>

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-09 Thread Bernd Edlinger
On Fri, 6 Dec 2013 11:51:15, Richard Biener wrote: > > On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger > wrote: >> Hi, >> >> On Thu, 5 Dec 2013 15:10:51, Richard Biener wrote: >>> >>> On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger >>> wrote: Hi Richard, I had just an idea how to so

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-06 Thread Bernd Edlinger
Richard, > Note I just want to help as well and I am not very familiar with > the details of the implementation here. So I'd rather have > a patch "obviously correct" to me - which expanding a condition > by several more checks isn't ;) > Thanks a lot, I understand that very well. Any help is wel

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-06 Thread Richard Biener
On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger wrote: > Hi, > > On Thu, 5 Dec 2013 15:10:51, Richard Biener wrote: >> >> On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger >> wrote: >>> Hi Richard, >>> >>> I had just an idea how to solve that recursion problem without completely >>> ignoring the >>

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-06 Thread Bernd Edlinger
> > Hmm, same patch as last time attached? > > Richard. > Yes, only the change-log had one redundant line. Bernd.

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-06 Thread Richard Biener
On Fri, Dec 6, 2013 at 11:15 AM, Bernd Edlinger wrote: > Hi, > > On Thu, 5 Dec 2013 15:10:51, Richard Biener wrote: >> >> On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger >> wrote: >>> Hi Richard, >>> >>> I had just an idea how to solve that recursion problem without completely >>> ignoring the >>

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-06 Thread Bernd Edlinger
Hi, On Thu, 5 Dec 2013 15:10:51, Richard Biener wrote: > > On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger > wrote: >> Hi Richard, >> >> I had just an idea how to solve that recursion problem without completely >> ignoring the >> memory mode. I hope you are gonna like it. >> >> This time I even a

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-05 Thread Richard Biener
On Thu, Dec 5, 2013 at 1:27 PM, Bernd Edlinger wrote: > Hi Richard, > > I had just an idea how to solve that recursion problem without completely > ignoring the > memory mode. I hope you are gonna like it. > > This time I even added a comment :-) Ehm, ... + /* If MODE has no size i.e. BLKm

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-05 Thread Bernd Edlinger
Hi Richard, I had just an idea how to solve that recursion problem without completely ignoring the memory mode. I hope you are gonna like it. This time I even added a comment :-) Ok for trunk after boot-strap and regression-testing? Bernd. On Tue, 3 Dec 2013 12:23:11, Richard Biener wrote: >

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 12:23:11, Richard Biener wrote: > > On Tue, Dec 3, 2013 at 12:01 PM, Bernd Edlinger > wrote: >> Hi, >> >> This is my proposal for ulimately getting rid of the nasty >> store_fixed_bit_field recursion. >> >> IMHO, the root of the recursion trouble is here: >> >> @@ -1007,12 +101

Re: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-03 Thread Richard Biener
On Tue, Dec 3, 2013 at 12:01 PM, Bernd Edlinger wrote: > Hi, > > This is my proposal for ulimately getting rid of the nasty > store_fixed_bit_field recursion. > > IMHO, the root of the recursion trouble is here: > > @@ -1007,12 +1013,8 @@ store_fixed_bit_field (rtx op0, unsigned > >if (MEM_P

[PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-03 Thread Bernd Edlinger
Hi, This is my proposal for ulimately getting rid of the nasty store_fixed_bit_field recursion. IMHO, the root of the recursion trouble is here: @@ -1007,12 +1013,8 @@ store_fixed_bit_field (rtx op0, unsigned    if (MEM_P (op0)) {   mode = GET_MODE (op0);   if (GET_MODE_BITSIZE (m