Re: [PATCH] Selftest framework (v7)

2016-06-07 Thread Trevor Saunders
On Tue, Jun 07, 2016 at 10:18:32AM -0400, David Malcolm wrote: > On Mon, 2016-06-06 at 22:14 -0400, Trevor Saunders wrote: > > On Mon, Jun 06, 2016 at 11:57:49PM +0200, Jakub Jelinek wrote: > > > On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > > > > > > As far as I can > > > > >

Re: [PATCH] Selftest framework (v7)

2016-06-07 Thread David Malcolm
On Mon, 2016-06-06 at 22:14 -0400, Trevor Saunders wrote: > On Mon, Jun 06, 2016 at 11:57:49PM +0200, Jakub Jelinek wrote: > > On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > > > > > As far as I can > > > > > tell this just involves moving the start of namespace > > > > > selfte

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Trevor Saunders
On Mon, Jun 06, 2016 at 11:57:49PM +0200, Jakub Jelinek wrote: > On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > > > > As far as I can > > > > tell this just involves moving the start of namespace selftest > > > > upwards a > > > > bit in the files where we have tests. > > > >

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Jakub Jelinek
On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > > > As far as I can > > > tell this just involves moving the start of namespace selftest > > > upwards a > > > bit in the files where we have tests. > > > > Yes, and it does seem cleaner to have all of the selftest code start > >

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Trevor Saunders
> > As far as I can > > tell this just involves moving the start of namespace selftest > > upwards a > > bit in the files where we have tests. > > Yes, and it does seem cleaner to have all of the selftest code start > like this: > > #if CHECKING_P What are we gaining by ifdefing this? I woul

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Bernd Schmidt
On 06/06/2016 04:17 PM, David Malcolm wrote: I'm testing a revised patch now, incorporating the above, and renaming s-selftests (plural) to s-selftest (singular) etc within gcc/Makefile.in as requested by Bernhard elsewhere in this thread. I assume that change is OK? Sure. Bernd

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread David Malcolm
On Sun, 2016-06-05 at 13:37 +0200, Bernd Schmidt wrote: > On 06/03/2016 09:12 PM, David Malcolm wrote: > > It's not clear to me if these approvals still hold. > > I was willing to go with it; I had a look through some of these > patches > and didn't spot anything untoward. To make it clear, this

Re: [PATCH] Selftest framework (v7)

2016-06-05 Thread Bernd Schmidt
On 06/03/2016 09:12 PM, David Malcolm wrote: It's not clear to me if these approvals still hold. I was willing to go with it; I had a look through some of these patches and didn't spot anything untoward. To make it clear, this patch is OK, with one tweak if possible: extend the namespace self

[PATCH] Selftest framework (v7)

2016-06-03 Thread David Malcolm
On Fri, 2016-06-03 at 01:21 +0200, Bernd Schmidt wrote: > On 06/02/2016 11:06 PM, David Malcolm wrote: > > gcc/ChangeLog: > > * Makefile.in (OBJS): Add function-tests.o, > > hash-map-tests.o, hash-set-tests.o, rtl-tests.o, > > selftest-run-tests.o. > > (OBJS-libcommon): Add selftest