Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-12 Thread Jonathan Wakely
On Wed, 12 Feb 2025 at 12:05, Matthew Malcomson wrote: > > Hi there -- since you've not pushed quite yet can I ask that you use the > following commit message instead of the existing one? > (Updated a few comments to match what has changed since I wrote that > message). > > Apologies for not notic

Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-12 Thread Matthew Malcomson
Hi there -- since you've not pushed quite yet can I ask that you use the following commit message instead of the existing one? (Updated a few comments to match what has changed since I wrote that message). Apologies for not noticing it earlier. libstdc++: Conditionally use floating-point

Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-08 Thread Jonathan Wakely
On Sat, 8 Feb 2025 at 10:55, Matthew Malcomson wrote: > > Hi Jonathan! > > Many thanks! Will learn the libstdc++ style eventually. > > I've run bootstrap & regression test on this, and did the manual checks > I mentioned before of compiling atomic_float/1.cc with clang and then > adding `+ 1` on

Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-08 Thread Matthew Malcomson
Hi Jonathan! Many thanks! Will learn the libstdc++ style eventually. I've run bootstrap & regression test on this, and did the manual checks I mentioned before of compiling atomic_float/1.cc with clang and then adding `+ 1` on the builtin codepath to check that the clang binary aborts while

Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-07 Thread Jonathan Wakely
On 05/02/25 13:43 +, Jonathan Wakely wrote: On 28/10/24 17:15 +, mmalcom...@nvidia.com wrote: From: Matthew Malcomson I noticed that the libstdc++ patch is essentially separate and figured I could send it upstream earlier to give reviewers more time to look at it. I am still working on

Re: [PATCH] SFINAE check for floating point fetch_add builtins in libstdc++

2025-02-05 Thread Jonathan Wakely
On 28/10/24 17:15 +, mmalcom...@nvidia.com wrote: From: Matthew Malcomson I noticed that the libstdc++ patch is essentially separate and figured I could send it upstream earlier to give reviewers more time to look at it. I am still working on adding the ability to use floating point types i