Re: [PATCH] S/390: Throw FE_INVALID exception in the fp2int libgcc routines

2014-02-06 Thread Joseph S. Myers
I have no further comments on the patch. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] S/390: Throw FE_INVALID exception in the fp2int libgcc routines

2014-02-06 Thread Andreas Krebbel
Here is a new version of the patch not limited to NaNs and Infs anymore. Bootstrapped and regtested on s390 with various options. -Andreas- 2014-02-06 Andreas Krebbel * config/s390/32/_fixdfdi.c: Throw invalid exception if number cannot be represented. * config/s390/3

Re: [PATCH] S/390: Throw FE_INVALID exception in the fp2int libgcc routines

2014-01-30 Thread Joseph S. Myers
On Thu, 30 Jan 2014, Andreas Krebbel wrote: > @@ -81,6 +91,8 @@ __fixdfdi (double a1) > l = (long long)1<<63; > if (!SIGND(dl1)) > l--; > + /* C99 Annex F.4 requires an "invalid" exception to be thrown. */ > + fexceptdiv (0.0, 0.0); > return l; My understandin

[PATCH] S/390: Throw FE_INVALID exception in the fp2int libgcc routines

2014-01-30 Thread Andreas Krebbel
Hi, our IEEE float to int conversion routines in libgcc do not throw the FE_INVALID exceptions according to C99 Annex F. Fixed with the attached patch. This fixes the Glibc test-ldouble tests on s390: < Failure: llrint (inf): Exception "Invalid operation" not set < Failure: llrint (-inf): Excepti