Re: [PATCH] Restore init_ggc_heuristics.

2019-11-19 Thread Richard Biener
On Tue, Nov 19, 2019 at 2:18 PM Martin Liška wrote: > > On 11/19/19 1:42 PM, Richard Biener wrote: > > Well, then call it from the caller of init_options_struct instead, > > right after it or after the > > langhook variant is called? > > Yes, that's definitely possible, there's a patch that I've j

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-19 Thread Martin Liška
s, Martin >From b868170d585354e3cfedb4b6076ec66d475fa66d Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 19 Nov 2019 13:55:40 +0100 Subject: [PATCH] Restore init_ggc_heuristics. gcc/ChangeLog: 2019-11-19 Martin Liska * toplev.c (general_init): Move the call... (toplev::main): .

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-19 Thread Richard Biener
On Tue, Nov 19, 2019 at 12:37 PM Martin Liška wrote: > > On 11/19/19 11:03 AM, Richard Biener wrote: > > On Mon, Nov 18, 2019 at 1:24 PM Martin Liška wrote: > >> > >> Hello. > >> > >> After my param to option transformation, we lost automatic GGC > >> detection. It's because init_ggc_heuristics i

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-19 Thread Martin Liška
On 11/19/19 11:03 AM, Richard Biener wrote: On Mon, Nov 18, 2019 at 1:24 PM Martin Liška wrote: Hello. After my param to option transformation, we lost automatic GGC detection. It's because init_ggc_heuristics is called before init_options_struct which memsets all the values to zero first. I

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-19 Thread Richard Biener
On Mon, Nov 18, 2019 at 1:24 PM Martin Liška wrote: > > Hello. > > After my param to option transformation, we lost automatic GGC > detection. It's because init_ggc_heuristics is called before > init_options_struct which memsets all the values to zero first. > > I've tested the patch with --enable

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-18 Thread Martin Liška
On 11/18/19 2:08 PM, Jan Hubicka wrote: You should be able to measure the difference building tramp3d on enable-checking=release compiler. I will include the patch in my next round of Firefox benchmark (probably tonight) unless you beat me. I verified that by printing the values in gcc_collect

Re: [PATCH] Restore init_ggc_heuristics.

2019-11-18 Thread Jan Hubicka
> Hello. > > After my param to option transformation, we lost automatic GGC > detection. It's because init_ggc_heuristics is called before > init_options_struct which memsets all the values to zero first. > > I've tested the patch with --enable-checking=release and I hope > Honza can test it more

[PATCH] Restore init_ggc_heuristics.

2019-11-18 Thread Martin Liška
Hello. After my param to option transformation, we lost automatic GGC detection. It's because init_ggc_heuristics is called before init_options_struct which memsets all the values to zero first. I've tested the patch with --enable-checking=release and I hope Honza can test it more? Patch can bo