Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:42 +0100, Jonathan Wakely wrote: On 14/06/24 11:37 +0100, Jonathan Wakely wrote: On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a ho

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:37 +0100, Jonathan Wakely wrote: On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 11:26 +0100, Jonathan Wakely wrote: On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that do

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 14/06/24 10:36 +0100, Jonathan Wakely wrote: On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that don't guarantee copy elision/return value optimizat

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-14 Thread Jonathan Wakely
On 07/06/24 19:40 +0100, Roger Sayle wrote: This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that don't guarantee copy elision/return value optimization. It doesn't though. The C++17 guaranteed c

Re: [analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-07 Thread David Malcolm
On Fri, 2024-06-07 at 19:40 +0100, Roger Sayle wrote: > > This patch restores bootstrap when using g++ 4.8 as a host compiler. > Returning a std::unique_ptr requires a std::move on C++ compilers > (pre-C++17) that don't guarantee copy elision/return value > optimization. > > Bootstrapped on x86_6

[analyzer PATCH] Restore bootstrap with g++ 4.8.

2024-06-07 Thread Roger Sayle
This patch restores bootstrap when using g++ 4.8 as a host compiler. Returning a std::unique_ptr requires a std::move on C++ compilers (pre-C++17) that don't guarantee copy elision/return value optimization. Bootstrapped on x86_64-pc-linux-gnu using both gcc 4.8.5 (system) and gcc 10.2.1 (using "

Re: [PATCH] Restore bootstrap on x86_64-pc-linux-gnu

2022-02-22 Thread Uros Bizjak via Gcc-patches
On Tue, Feb 22, 2022 at 2:40 PM Roger Sayle wrote: > > > > This patch resolves the bootstrap failure on x86_64-pc-linux-gnu. > > Is this sufficiently "obvious" in stage4, or should I wait for the bootstrap > > and regression testing to complete? Please just bootstrap the compiler. > > > 2022-02-

[PATCH] Restore bootstrap on x86_64-pc-linux-gnu

2022-02-22 Thread Roger Sayle
This patch resolves the bootstrap failure on x86_64-pc-linux-gnu. Is this sufficiently "obvious" in stage4, or should I wait for the bootstrap and regression testing to complete? 2022-02-22 Roger Sayle gcc/ChangeLog * config/i386/i386-expand.cc (ix86_expand_cmpxchg_loop): Restore

[PATCH] Restore bootstrap

2016-09-23 Thread Richard Biener
Committed as obvious. 2016-09-23 Richard Biener * hooks.h (hook_uint_uintp_false): Declare. Index: gcc/hooks.h === --- gcc/hooks.h (revision 240386) +++ gcc/hooks.h (working copy) @@ -76,6 +76,7 @@ extern void hook_void_

Re: [PATCH]: Restore bootstrap with gcc < 4.3

2016-06-13 Thread Richard Biener
On Mon, Jun 13, 2016 at 11:23 AM, Uros Bizjak wrote: > Hello! > > The new test finalization self tests fail wigh gcc < 4.3 due to the > way need_finalization_p is defined: > > template > static inline bool > need_finalization_p () > { > #if GCC_VERSION >= 4003 > return !__has_trivial_destructor

[PATCH]: Restore bootstrap with gcc < 4.3

2016-06-13 Thread Uros Bizjak
Hello! The new test finalization self tests fail wigh gcc < 4.3 due to the way need_finalization_p is defined: template static inline bool need_finalization_p () { #if GCC_VERSION >= 4003 return !__has_trivial_destructor (T); #else return true; #endif } It is obvious that checking for AS

Re: [patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-25 Thread FX
>> 2014-11-24 Rohit >> >> PR bootstrap/63703 >> * config/rs6000/darwin.h (REGISTER_NAMES): Update based on 32 newly >> added GCC hard register numbers for SPE high registers. >> > > IMO, it's obvious, and as you say, doesn't touch any other target. After further confirmations

Re: [patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-24 Thread Iain Sandoe
On 24 Nov 2014, at 17:02, FX wrote: > Bootstrap is currently broken on ppc-darwin due to PR63703 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63703). > This is also broken on 4.9, and actually made it into the 4.9.2 release. > > This patch fixes it, restores bootstrap (well, it gets cc1 to b

[patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-24 Thread FX
Bootstrap is currently broken on ppc-darwin due to PR63703 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63703). This is also broken on 4.9, and actually made it into the 4.9.2 release. This patch fixes it, restores bootstrap (well, it gets cc1 to build, at least… I don’t have a ppc to test the

[PATCH] Restore bootstrap (PR61757)

2014-07-10 Thread Richard Biener
The following patch partially reverts r212352 to restore bootstrap on i585-linux (where I reproduced and verified the fix). It makes phicprop honor that loop-depth condition again which doing not seems to cause a latent bug to pop up which miscompiles the stage2 compiler which in turn miscompiles

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-18 Thread Richard Guenther
On Wed, May 18, 2011 at 10:44 PM, Toon Moene wrote: > On 05/18/2011 10:31 PM, Richard Guenther wrote: > >> Not that I'm too excited to see GCC built with a C++ compiler (or even C++ >> features being used). > > Hmmm, you think using "false" as a value for a pointer-returning function is > just A-O

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-18 Thread Toon Moene
On 05/18/2011 10:31 PM, Richard Guenther wrote: Not that I'm too excited to see GCC built with a C++ compiler (or even C++ features being used). Hmmm, you think using "false" as a value for a pointer-returning function is just A-OK ? Duh, I'm glad I'm using Fortran, where the programmer isn

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-18 Thread Richard Guenther
On Wed, May 18, 2011 at 10:17 PM, Toon Moene wrote: > On 05/18/2011 05:41 AM, Gabriel Dos Reis wrote: > >> On Tue, May 17, 2011 at 2:46 PM, Toon Moene  wrote: > >>> On 05/17/2011 08:32 PM, Uros Bizjak wrote: >>> Tested on x86_64-pc-linux-gnu {, m32} with --enable-build-with-cxx. Committe

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-18 Thread Toon Moene
On 05/18/2011 05:41 AM, Gabriel Dos Reis wrote: On Tue, May 17, 2011 at 2:46 PM, Toon Moene wrote: On 05/17/2011 08:32 PM, Uros Bizjak wrote: Tested on x86_64-pc-linux-gnu {, m32} with --enable-build-with-cxx. Committed to mainline SVN as obvious. Does that mean that I can now remove the

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-17 Thread Gabriel Dos Reis
On Tue, May 17, 2011 at 2:46 PM, Toon Moene wrote: > On 05/17/2011 08:32 PM, Uros Bizjak wrote: > >> Tested on x86_64-pc-linux-gnu {, m32} with --enable-build-with-cxx. >> Committed to mainline SVN as obvious. > > Does that mean that I can now remove the --disable-werror from my daily C++ > bootst

Re: [PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-17 Thread Toon Moene
On 05/17/2011 08:32 PM, Uros Bizjak wrote: Tested on x86_64-pc-linux-gnu {, m32} with --enable-build-with-cxx. Committed to mainline SVN as obvious. Does that mean that I can now remove the --disable-werror from my daily C++ bootstrap run ? It's great that some people understand the intrica

[PATCH]: Restore bootstrap with --enable-build-with-cxx

2011-05-17 Thread Uros Bizjak
Hello! 2011-05-17 Uros Bizjak * ipa-inline-analysis.c (inline_node_duplication_hook): Initialize info->entry with 0 * tree-inline.c (maybe_inline_call_in_expr): Initialize id.transform_lang_insert_block with NULL. Tested on x86_64-pc-linux-gnu {, m32} with --e